Merge pull request thaliproject#132 from zeroleak/fix-leak-socket

Possible memory leak: close socket after use

Author: yaronyg

universal/src/main/java/com/msopentech/thali/toronionproxy/TorConfigBuilder.java

@@ -54,13 +54,20 @@ private static boolean isNullOrEmpty(String value) {
     }
 
     private static boolean isLocalPortOpen(int port) {
+        Socket socket = null;
         try {
-            Socket socket = new Socket();
+            socket = new Socket();
             socket.connect(new InetSocketAddress("127.0.0.1", port), 500);
-            socket.close();
             return true;
         } catch (Exception e) {
             return false;
+        } finally {
+            if (socket  != null) {
+                try {
+                    socket.close();
+                } catch (Exception ee) {
+                }
+            }
         }
     }