You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In several places, we import dependencies that are already re-exported within our crate. For example, in crates/miden-objects/src/batch/note_tree.rs:
use miden_crypto::{
hash::rpo::RpoDigest,
merkle::{MerkleError,SimpleSmt},};
Similarly, in crates/miden-objects/src/account/account_id/id_prefix.rs:
use miden_crypto::utils::ByteWriter;use vm_core::{
utils::{ByteReader,Deserializable,Serializable},Felt,};use vm_processor::DeserializationError;
These imports could be replaced with crate:: references where applicable.
How should it be done?
Wherever possible, external dependency imports should be replaced with their re-exported equivalents using crate::???. This helps maintain consistency and may allow us to remove unnecessary dependencies.
Once the replacements are made, tools like cargo-machete can help identify and remove unused dependencies.
When is this task done?
All eligible imports are replaced with crate:: references.
Any redundant dependencies are removed where possible.
Additional context
No response
The text was updated successfully, but these errors were encountered:
What should be done?
In several places, we import dependencies that are already re-exported within our crate. For example, in
crates/miden-objects/src/batch/note_tree.rs
:Similarly, in
crates/miden-objects/src/account/account_id/id_prefix.rs
:These imports could be replaced with
crate::
references where applicable.How should it be done?
Wherever possible, external dependency imports should be replaced with their re-exported equivalents using
crate::???
. This helps maintain consistency and may allow us to remove unnecessary dependencies.Once the replacements are made, tools like
cargo-machete
can help identify and remove unused dependencies.When is this task done?
crate::
references.Additional context
No response
The text was updated successfully, but these errors were encountered: