refactor(api): avoid application naming in usecase

Co-authored-by: Eric Lim <[email protected]>

Author: yannbertrand

api/src/devcomp/application/passages/controller.js

@@ -20,7 +20,7 @@ const verifyAndSaveAnswer = async function (request, h, { usecases, elementAnswe
 const terminate = async function (request, h, { usecases, passageSerializer }) {
   const { passageId } = request.params;
   const requestTimestamp = requestResponseUtils.extractTimestampFromRequest(request);
-  const updatedPassage = await usecases.terminatePassage({ passageId, requestTimestamp });
+  const updatedPassage = await usecases.terminatePassage({ passageId, occurredAt: new Date(requestTimestamp) });
   return passageSerializer.serialize(updatedPassage);
 };
 

api/src/devcomp/domain/usecases/terminate-passage.js

@@ -5,7 +5,7 @@ import { PassageTerminatedEvent } from '../models/passage-events/passage-events.
 
 const terminatePassage = withTransaction(async function ({
   passageId,
-  requestTimestamp,
+  occurredAt,
   passageRepository,
   passageEventRepository,
 }) {
@@ -15,10 +15,7 @@ const terminatePassage = withTransaction(async function ({
   }
   passage.terminate();
   const terminatedPassage = await passageRepository.update({ passage });
-  const event = new PassageTerminatedEvent({
-    passageId: terminatedPassage.id,
-    occurredAt: new Date(requestTimestamp),
-  });
+  const event = new PassageTerminatedEvent({ passageId, occurredAt });
   await passageEventRepository.record(event);
   return terminatedPassage;
 });

api/tests/devcomp/unit/application/passages/controller_test.js

@@ -91,15 +91,17 @@ describe('Unit | Devcomp | Application | Passages | Controller', function () {
   describe('#terminate', function () {
     it('should call terminate use-case and return serialized passage', async function () {
       // given
-      const requestDate = new Date('2025-01-01').getTime();
+      const requestTimestamp = new Date('2025-01-01').getTime();
       const serializedPassage = Symbol('serialized modules');
       const passageId = Symbol('passage-id');
       const passage = Symbol('passage');
-      const extractTimestampStub = sinon.stub(requestResponseUtils, 'extractTimestampFromRequest').returns(requestDate);
+      const extractTimestampStub = sinon
+        .stub(requestResponseUtils, 'extractTimestampFromRequest')
+        .returns(requestTimestamp);
       const usecases = {
         terminatePassage: sinon.stub(),
       };
-      usecases.terminatePassage.withArgs({ passageId, requestTimestamp: requestDate }).returns(passage);
+      usecases.terminatePassage.withArgs({ passageId, occurredAt: new Date(requestTimestamp) }).returns(passage);
       const passageSerializer = {
         serialize: sinon.stub(),
       };

api/tests/devcomp/unit/domain/usecases/terminate-passage_test.js

@@ -54,7 +54,7 @@ describe('Unit | Devcomp | Domain | UseCases | terminate-passage', function () {
       it('should call terminate method and update passage and return it, then record an event', async function () {
         // given
         const passageId = Symbol('passageId');
-        const requestTimestamp = new Date('2025-01-01').getTime();
+        const occurredAt = new Date('2025-01-01');
 
         const passageRepository = {
           get: sinon.stub(),
@@ -76,15 +76,12 @@ describe('Unit | Devcomp | Domain | UseCases | terminate-passage', function () {
         };
         passageRepository.update.withArgs({ passage }).resolves(updatedPassage);
 
-        const event = new PassageTerminatedEvent({
-          passageId: updatedPassage.id,
-          occurredAt: new Date(requestTimestamp),
-        });
+        const event = new PassageTerminatedEvent({ passageId, occurredAt });
 
         // when
         const returnedPassage = await terminatePassage({
           passageId,
-          requestTimestamp,
+          occurredAt,
           passageRepository,
           passageEventRepository,
         });