Skip to content

Commit d4e5589

Browse files
committed
feat(api): change create passage module check
by returning module for record purposes
1 parent 64b8a18 commit d4e5589

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

api/src/devcomp/domain/usecases/create-passage.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@ import { NotFoundError } from '../../../shared/domain/errors.js';
22
import { ModuleDoesNotExistError } from '../errors.js';
33

44
const createPassage = async function ({ moduleId, userId, moduleRepository, passageRepository, userRepository }) {
5-
await _verifyIfModuleExists({ moduleId, moduleRepository });
5+
await _getModule({ moduleId, moduleRepository });
66
if (userId !== null) {
77
await userRepository.get(userId);
88
}
99
return passageRepository.save({ moduleId, userId });
1010
};
1111

12-
async function _verifyIfModuleExists({ moduleId, moduleRepository }) {
12+
async function _getModule({ moduleId, moduleRepository }) {
1313
try {
14-
await moduleRepository.getBySlug({ slug: moduleId });
14+
return await moduleRepository.getBySlug({ slug: moduleId });
1515
} catch (e) {
1616
if (e instanceof NotFoundError) {
1717
throw new ModuleDoesNotExistError();

api/tests/devcomp/unit/domain/usecases/create-passage_test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { catchErr, expect, sinon } from '../../../../test-helper.js';
66

77
describe('Unit | Devcomp | Domain | UseCases | create-passage', function () {
88
describe('when module does not exist', function () {
9-
it('should throw an ModuleNotExists', async function () {
9+
it('should throw a ModuleDoesNotExist error', async function () {
1010
// given
1111
const moduleId = Symbol('moduleId');
1212

@@ -24,7 +24,7 @@ describe('Unit | Devcomp | Domain | UseCases | create-passage', function () {
2424
});
2525

2626
describe('when user does not exist', function () {
27-
it('should throw an UserNotExists', async function () {
27+
it('should throw an UserNotExists error', async function () {
2828
// given
2929
const userId = Symbol('userId');
3030

0 commit comments

Comments
 (0)