From 190d4f59b51f74a5b87985e5d828118ae94d7118 Mon Sep 17 00:00:00 2001 From: Andreia Pena Date: Tue, 21 May 2024 18:23:05 +0200 Subject: [PATCH 1/4] bump(certif): Update dependency @1024pix/pix-ui to ^46.3.1 --- certif/package-lock.json | 9 ++++----- certif/package.json | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/certif/package-lock.json b/certif/package-lock.json index 5671bae6505..184399eb512 100644 --- a/certif/package-lock.json +++ b/certif/package-lock.json @@ -12,7 +12,7 @@ "devDependencies": { "@1024pix/ember-testing-library": "^1.1.0", "@1024pix/eslint-config": "^1.3.0", - "@1024pix/pix-ui": "^46.0.3", + "@1024pix/pix-ui": "^46.3.1", "@1024pix/stylelint-config": "^5.1.14", "@babel/eslint-parser": "^7.22.15", "@babel/plugin-proposal-decorators": "^7.22.15", @@ -131,12 +131,11 @@ "dev": true }, "node_modules/@1024pix/pix-ui": { - "version": "46.0.3", - "resolved": "https://registry.npmjs.org/@1024pix/pix-ui/-/pix-ui-46.0.3.tgz", - "integrity": "sha512-SivXY7u90lpNaXJ9JrJy4irkifADcQKafX5q3jYFZz24fFf4wBNUVvggMz4JmLt0aaVJ3MMd5/EOw9+Cy4hEKQ==", + "version": "46.3.1", + "resolved": "https://registry.npmjs.org/@1024pix/pix-ui/-/pix-ui-46.3.1.tgz", + "integrity": "sha512-jMYOGZOB+bl7Ytu3PM4YWVVegigUEvjnlUYWLd9eQEXMD4JfpVpefTAwZ80fO5sHH0b1b9aj/vPM12DeQ98PSQ==", "dev": true, "hasInstallScript": true, - "license": "MIT", "dependencies": { "@formatjs/intl": "^2.5.1", "ember-auto-import": "^2.5.0", diff --git a/certif/package.json b/certif/package.json index 18111e14f7d..674e9f55201 100644 --- a/certif/package.json +++ b/certif/package.json @@ -43,7 +43,7 @@ "devDependencies": { "@1024pix/ember-testing-library": "^1.1.0", "@1024pix/eslint-config": "^1.3.0", - "@1024pix/pix-ui": "^46.0.3", + "@1024pix/pix-ui": "^46.3.1", "@1024pix/stylelint-config": "^5.1.14", "@babel/eslint-parser": "^7.22.15", "@babel/plugin-proposal-decorators": "^7.22.15", From aaf6d24f930a5b5aec99d3d0d8db41d8e25cd048 Mon Sep 17 00:00:00 2001 From: Andreia Pena Date: Tue, 21 May 2024 18:47:30 +0200 Subject: [PATCH 2/4] refactor(certif): remove useless class --- certif/app/components/enrolled-candidates.hbs | 7 +------ .../sessions/details/certification-candidates.scss | 6 ------ 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/certif/app/components/enrolled-candidates.hbs b/certif/app/components/enrolled-candidates.hbs index e399c02dffd..9b796daac62 100644 --- a/certif/app/components/enrolled-candidates.hbs +++ b/certif/app/components/enrolled-candidates.hbs @@ -13,12 +13,7 @@ {{t "pages.sessions.detail.candidates.list.actions.inscription-multiple.label"}} {{else}} - + {{t "pages.sessions.detail.candidates.list.actions.inscription.label"}} {{/if}} diff --git a/certif/app/styles/pages/authenticated/sessions/details/certification-candidates.scss b/certif/app/styles/pages/authenticated/sessions/details/certification-candidates.scss index 0b1b641c90a..20a30095160 100644 --- a/certif/app/styles/pages/authenticated/sessions/details/certification-candidates.scss +++ b/certif/app/styles/pages/authenticated/sessions/details/certification-candidates.scss @@ -132,12 +132,6 @@ } } -.certification-candidates-add-button { - &__text { - font-size: 1rem; - } -} - .certification-candidates-table td, .certification-candidates-table th { padding-left: 16px; } From 25c33ee038967764937b0c2bdd4538da853786e5 Mon Sep 17 00:00:00 2001 From: Andreia Pena Date: Tue, 21 May 2024 18:48:22 +0200 Subject: [PATCH 3/4] refactor(certif): change padding to fix border-bottom current nav element --- certif/app/styles/pages/authenticated/sessions/details.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/certif/app/styles/pages/authenticated/sessions/details.scss b/certif/app/styles/pages/authenticated/sessions/details.scss index 94a5c30fa3f..db210b13b59 100644 --- a/certif/app/styles/pages/authenticated/sessions/details.scss +++ b/certif/app/styles/pages/authenticated/sessions/details.scss @@ -206,10 +206,11 @@ gap: 8px; align-items: center; justify-content: right; - padding: 12px 16px; + padding: var(--pix-spacing-3x) var(--pix-spacing-4x); @include device-is("desktop") { flex-direction: row; + padding: var(--pix-spacing-2x) var(--pix-spacing-4x); } } From 8409693294d5c82455a99889c060e08b7eacb404 Mon Sep 17 00:00:00 2001 From: Andreia Pena Date: Tue, 21 May 2024 18:48:48 +0200 Subject: [PATCH 4/4] refactor(certif): remove useless elements to fix pix ui bugs --- certif/app/components/members-list-item.hbs | 23 +++++++------- .../uncompleted-reports-information-step.hbs | 30 +++++++++---------- 2 files changed, 24 insertions(+), 29 deletions(-) diff --git a/certif/app/components/members-list-item.hbs b/certif/app/components/members-list-item.hbs index 9f6e479fbaf..3de6476dd8c 100644 --- a/certif/app/components/members-list-item.hbs +++ b/certif/app/components/members-list-item.hbs @@ -3,19 +3,16 @@ {{@member.firstName}} {{#if this.isEditionMode}} -
- - - <:label>{{t "pages.team.members.actions.select-role.label"}} - -
+ + <:label>{{t "pages.team.members.actions.select-role.label"}} + {{else}} {{@member.roleLabel}} {{/if}} diff --git a/certif/app/components/session-finalization/uncompleted-reports-information-step.hbs b/certif/app/components/session-finalization/uncompleted-reports-information-step.hbs index 946e4fdaa47..893bfc01ba3 100644 --- a/certif/app/components/session-finalization/uncompleted-reports-information-step.hbs +++ b/certif/app/components/session-finalization/uncompleted-reports-information-step.hbs @@ -105,22 +105,20 @@ -
- - <:label>{{t - "pages.session-finalization.reporting.uncompleted-reports-information.table.labels.abandonment-reason-label" - }} - -
+ + <:label>{{t + "pages.session-finalization.reporting.uncompleted-reports-information.table.labels.abandonment-reason-label" + }} + {{/each}}