Skip to content

Commit bd6fcd5

Browse files
authored
Orient cameras right-side-up (mrdoob#24921)
1 parent c965d3b commit bd6fcd5

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

Diff for: src/cameras/CubeCamera.js

+8-7
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import { NoToneMapping } from '../constants.js';
22
import { Object3D } from '../core/Object3D.js';
33
import { PerspectiveCamera } from './PerspectiveCamera.js';
44

5-
const fov = 90, aspect = 1;
5+
const fov = - 90; // negative fov is not an error
6+
const aspect = 1;
67

78
class CubeCamera extends Object3D {
89

@@ -16,37 +17,37 @@ class CubeCamera extends Object3D {
1617

1718
const cameraPX = new PerspectiveCamera( fov, aspect, near, far );
1819
cameraPX.layers = this.layers;
19-
cameraPX.up.set( 0, - 1, 0 );
20+
cameraPX.up.set( 0, 1, 0 );
2021
cameraPX.lookAt( 1, 0, 0 );
2122
this.add( cameraPX );
2223

2324
const cameraNX = new PerspectiveCamera( fov, aspect, near, far );
2425
cameraNX.layers = this.layers;
25-
cameraNX.up.set( 0, - 1, 0 );
26+
cameraNX.up.set( 0, 1, 0 );
2627
cameraNX.lookAt( - 1, 0, 0 );
2728
this.add( cameraNX );
2829

2930
const cameraPY = new PerspectiveCamera( fov, aspect, near, far );
3031
cameraPY.layers = this.layers;
31-
cameraPY.up.set( 0, 0, 1 );
32+
cameraPY.up.set( 0, 0, - 1 );
3233
cameraPY.lookAt( 0, 1, 0 );
3334
this.add( cameraPY );
3435

3536
const cameraNY = new PerspectiveCamera( fov, aspect, near, far );
3637
cameraNY.layers = this.layers;
37-
cameraNY.up.set( 0, 0, - 1 );
38+
cameraNY.up.set( 0, 0, 1 );
3839
cameraNY.lookAt( 0, - 1, 0 );
3940
this.add( cameraNY );
4041

4142
const cameraPZ = new PerspectiveCamera( fov, aspect, near, far );
4243
cameraPZ.layers = this.layers;
43-
cameraPZ.up.set( 0, - 1, 0 );
44+
cameraPZ.up.set( 0, 1, 0 );
4445
cameraPZ.lookAt( 0, 0, 1 );
4546
this.add( cameraPZ );
4647

4748
const cameraNZ = new PerspectiveCamera( fov, aspect, near, far );
4849
cameraNZ.layers = this.layers;
49-
cameraNZ.up.set( 0, - 1, 0 );
50+
cameraNZ.up.set( 0, 1, 0 );
5051
cameraNZ.lookAt( 0, 0, - 1 );
5152
this.add( cameraNZ );
5253

0 commit comments

Comments
 (0)