Skip to content

Commit df4a3a9

Browse files
authored
PointLight/SpotLight: Change default decay to 2 (mrdoob#23897)
* PointLight/SpotLight: Change default decay to 2. * Updated screenshots. * Updated screenshots. * Update screenshot. * Update screenshot.
1 parent 87c581c commit df4a3a9

9 files changed

+4
-4
lines changed

Diff for: examples/screenshots/webgl_loader_md2.jpg

-6.05 KB
Loading

Diff for: examples/screenshots/webgl_materials_normalmap.jpg

-1.56 KB
Loading
-750 Bytes
Loading

Diff for: examples/screenshots/webgl_mirror.jpg

-3.13 KB
Loading

Diff for: examples/screenshots/webgl_portal.jpg

-2.24 KB
Loading

Diff for: examples/screenshots/webgl_refraction.jpg

-2.11 KB
Loading

Diff for: examples/screenshots/webgl_shadowmap_pointlight.jpg

-6.44 KB
Loading

Diff for: src/lights/PointLight.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { PointLightShadow } from './PointLightShadow.js';
33

44
class PointLight extends Light {
55

6-
constructor( color, intensity, distance = 0, decay = 1 ) {
6+
constructor( color, intensity, distance = 0, decay = 2 ) {
77

88
super( color, intensity );
99

@@ -12,7 +12,7 @@ class PointLight extends Light {
1212
this.type = 'PointLight';
1313

1414
this.distance = distance;
15-
this.decay = decay; // for physically correct lights, should be 2.
15+
this.decay = decay;
1616

1717
this.shadow = new PointLightShadow();
1818

Diff for: src/lights/SpotLight.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { Object3D } from '../core/Object3D.js';
44

55
class SpotLight extends Light {
66

7-
constructor( color, intensity, distance = 0, angle = Math.PI / 3, penumbra = 0, decay = 1 ) {
7+
constructor( color, intensity, distance = 0, angle = Math.PI / 3, penumbra = 0, decay = 2 ) {
88

99
super( color, intensity );
1010

@@ -20,7 +20,7 @@ class SpotLight extends Light {
2020
this.distance = distance;
2121
this.angle = angle;
2222
this.penumbra = penumbra;
23-
this.decay = decay; // for physically correct lights, should be 2.
23+
this.decay = decay;
2424

2525
this.map = null;
2626

0 commit comments

Comments
 (0)