Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve translations on TLS error message #174

Closed
wants to merge 1 commit into from

Conversation

Zulgrib
Copy link

@Zulgrib Zulgrib commented Jan 30, 2023

Questions Answers
Description? Modify French strings to not wrongfully blame cURL in all situations. Does not include additional ways to check to be more precise in the error message
Stop always blaming cURL when unexpected http code are received when testing TLS version in French
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Partially Fixes #173.
How to test? Forcibly make tls test file return a 404 and check error returned in french in the back office paypal module config

Modify French strings to not wrongfully blame cURL in all situations.
Does not include additional ways to check to be more precise in the error message
@clotairer clotairer changed the title Update fr.php Improve translations on TLS error message Jan 30, 2023
@kgleizes
Copy link
Collaborator

This issue did not move since a long time.
And this part have been improved on 6.0.0 and we will make new evolutions to have better error messages
in the future.

Thank you for this suggestion.

@kgleizes kgleizes closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paypal module wrongfully state cURL is not enabled
2 participants