Skip to content

Commit 748b333

Browse files
committed
Merge branch 'ISSUE_5373' into ISSUE__5412
2 parents 499403c + e2207e0 commit 748b333

File tree

2 files changed

+8
-19
lines changed

2 files changed

+8
-19
lines changed

backend/src/v5/services/sso/frontegg/index.js

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -102,24 +102,13 @@ Frontegg.getUserInfoFromToken = async (token) => {
102102
}
103103
};
104104

105-
Frontegg.validateAndRefreshToken = async ({ token /* refreshToken */ }) => {
105+
Frontegg.validateToken = async ({ token }, userId) => {
106106
try {
107107
const client = await getIdentityClient();
108-
const user = await client.validateToken(token);
109-
110-
/* try {
111-
const payload = {
112-
grant_type: 'refresh_token',
113-
refresh_token: refreshToken,
114-
};
115-
116-
const { data } = await post(`${config.appUrl}/oauth/token`, payload, { headers: await basicHeader() });
117-
} catch (err) {
118-
119-
console.log(err);
120-
} */
121-
122-
return user;
108+
const { sub } = await client.validateToken(token);
109+
if (sub !== userId) {
110+
throw new Error('User ID mismatched');
111+
}
123112
} catch (err) {
124113
throw new Error(`Failed to validate user token: ${err.message}`);
125114
}

backend/src/v5/utils/sessions.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const { apiUrls } = require('./config');
2222
const { deleteIfUndefined } = require('./helper/objects');
2323
const { events } = require('../services/eventsManager/eventsManager.constants');
2424
const { publish } = require('../services/eventsManager/eventsManager');
25-
const { validateAndRefreshToken } = require('../services/sso/frontegg');
25+
const { validateToken } = require('../services/sso/frontegg');
2626

2727
const referrerMatch = (sessionReferrer, headerReferrer) => {
2828
const domain = getURLDomain(headerReferrer);
@@ -43,8 +43,8 @@ const validateCookie = async (session, cookies, headers) => {
4343

4444
if (internalSessionValid) {
4545
try {
46-
const user = await validateAndRefreshToken(session.user.auth.tokenInfo);
47-
return user.sub === session.user.auth.userId;
46+
await validateToken(session.user.auth.tokenInfo, session.user.auth.userId);
47+
return true;
4848
} catch (err) {
4949
return false;
5050
}

0 commit comments

Comments
 (0)