Skip to content

Commit c55efdf

Browse files
committed
ISSUE #5374 - avoid creating extra redux call
1 parent c9b4e75 commit c55efdf

File tree

2 files changed

+1
-12
lines changed

2 files changed

+1
-12
lines changed

frontend/src/v5/store/tickets/card/ticketsCard.redux.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ export const { Types: TicketsCardTypes, Creators: TicketsCardActions } = createA
2828
setSelectedTicket: ['ticketId'],
2929
setSelectedTemplate: ['templateId'],
3030
setSelectedTicketPin: ['pinId'],
31-
setFilters: ['filters'],
3231
upsertFilter: ['filter'],
3332
deleteFilter: ['filter'],
3433
resetFilters: [],
@@ -94,13 +93,6 @@ export const setPinToDrop = (state: ITicketsCardState, { pinToDrop }: SetPinToDr
9493
};
9594

9695
const getFilterKey = ({ module, property, type }: CardFilter): TicketFilterKey => `${module}.${property}.${type}`;
97-
export const setFilters = (state: ITicketsCardState, { filters }: SetFiltersAction) => {
98-
filters.forEach((filter) => {
99-
const path = getFilterKey(filter);
100-
state.filters[path] = filter.filter;
101-
});
102-
};
103-
10496
export const upsertFilter = (state: ITicketsCardState, { filter }: UpsertFilterAction) => {
10597
const path = getFilterKey(filter);
10698
state.filters[path] = filter.filter;
@@ -152,7 +144,6 @@ export const ticketsCardReducer = createReducer(INITIAL_STATE, produceAll({
152144
[TicketsCardTypes.SET_SELECTED_TEMPLATE]: setSelectedTemplate,
153145
[TicketsCardTypes.SET_SELECTED_TICKET_PIN]: setSelectedTicketPin,
154146
[TicketsCardTypes.SET_PIN_TO_DROP]: setPinToDrop,
155-
[TicketsCardTypes.SET_FILTERS]: setFilters,
156147
[TicketsCardTypes.UPSERT_FILTER]: upsertFilter,
157148
[TicketsCardTypes.DELETE_FILTER]: deleteFilter,
158149
[TicketsCardTypes.RESET_FILTERS]: resetFilters,
@@ -169,7 +160,6 @@ export type SetSelectedTicketAction = Action<'SET_SELECTED_TICKET'> & { ticketId
169160
export type SetSelectedTemplateAction = Action<'SET_SELECTED_TEMPLATE'> & { templateId: string };
170161
export type SetSelectedTicketPinAction = Action<'SET_SELECTED_TICKET_PIN'> & { pinId: string };
171162
export type SetPinToDropAction = Action<'SET_PIN_TO_DROP'> & { pinToDrop: string };
172-
export type SetFiltersAction = Action<'SET_FILTERS'> & { filters: CardFilter[] };
173163
export type UpsertFilterAction = Action<'UPSERT_FILTER'> & { filter: CardFilter };
174164
export type DeleteFilterAction = Action<'DELETE_FILTER'> & { filter: CardFilter };
175165
export type ResetFiltersAction = Action<'RESET_FILTERS'>;
@@ -189,7 +179,6 @@ export interface ITicketsCardActionCreators {
189179
setSelectedTemplate: (templateId: string) => SetSelectedTemplateAction,
190180
setSelectedTicketPin: (pinId: string) => SetSelectedTicketPinAction,
191181
setPinToDrop: (pinToDrop: string) => SetPinToDropAction,
192-
setFilters: (filters: CardFilter[]) => SetFiltersAction,
193182
upsertFilter: (filter: CardFilter) => UpsertFilterAction,
194183
deleteFilter: (filter: CardFilter) => DeleteFilterAction,
195184
resetFilters: () => ResetFiltersAction,

frontend/src/v5/ui/routes/viewer/defaultTicketFiltersSetter/defaultTicketFiltersSetter.component.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ export const DefaultTicketFiltersSetter = () => {
9999
if (hasTicketData) {
100100
const ticketCodes = ticketSearchParam.filter((query) => TICKET_CODE_REGEX.test(query)).map((q) => q.toUpperCase());
101101
const filters: CardFilter[] = ticketCodes.length ? getTicketFiltersFromURL(ticketCodes) : getNonCompletedTicketFilters();
102-
TicketsCardActionsDispatchers.setFilters(filters);
102+
filters.forEach(TicketsCardActionsDispatchers.upsertFilter);
103103
ViewerGuiActionsDispatchers.setPanelVisibility(VIEWER_PANELS.TICKETS, true);
104104
setTicketSearchParam();
105105
}

0 commit comments

Comments
 (0)