ISSUE #4642 - Now if the de selected view in ticket doesn change it doesnt refresh the view, missing translation is no longer littering the console

Author: sanmont3drepo

frontend/src/main.tsx

@@ -30,7 +30,7 @@ import { Root as V5Root } from '@/v5/ui/routes';
 
 import { UnityUtil } from '@/globals/unity-util';
 import { clientConfigService } from '@/v4/services/clientConfig';
-import { formatMessage, getIntlProviderProps, initializeIntl } from '@/v5/services/intl';
+import { formatMessage, getIntl, initializeIntl } from '@/v5/services/intl';
 import { initializeActionsDispatchers } from '@/v5/helpers/actionsDistpatchers.helper';
 import { IntlProvider } from 'react-intl';
 import { LocalizationProvider } from '@mui/x-date-pickers/LocalizationProvider';
@@ -68,7 +68,7 @@ const render = () => {
 	ReactDOM.render(
 		<Provider store={store as any}>
 			<ConnectedRouter history={history as History}>
-				<IntlProvider {...getIntlProviderProps()}>
+				<IntlProvider {...getIntl()}>
 					<LocalizationProvider dateAdapter={AdapterDayjs}>
 						<Switch>
 							<Route exact path="/">

frontend/src/v4/routes/viewerGui/viewerGui.component.tsx

@@ -16,9 +16,12 @@
  */
 
 import { Tickets } from '@/v5/ui/routes/viewer/tickets/tickets.component';
-import { isEmpty } from 'lodash';
+import { isEmpty, isEqual } from 'lodash';
 import { PureComponent } from 'react';
 import { Toolbar } from '@/v5/ui/routes/viewer/toolbar/toolbar.component';
+import { ITicket } from '@/v5/store/tickets/tickets.types';
+import { goToView } from '@/v5/helpers/viewpoint.helpers';
+import { AdditionalProperties } from '@/v5/ui/routes/viewer/tickets/tickets.constants';
 import { VIEWER_EVENTS } from '../../constants/viewer';
 import { getViewerLeftPanels, VIEWER_PANELS } from '../../constants/viewerGui';
 import { getWindowHeight, getWindowWidth, renderWhenTrue } from '../../helpers/rendering';
@@ -67,6 +70,7 @@ interface IProps {
 	rightPanels: string[];
 	draggablePanels: string[];
 	disabledPanelButtons: Set<string>;
+	selectedTicket: ITicket | null | undefined;
 	stopListenOnSelections: () => void;
 	stopListenOnModelLoaded: () => void;
 	stopListenOnClickPin: () => void;
@@ -181,6 +185,14 @@ export class ViewerGui extends PureComponent<IProps, IState> {
 			this.props.setPanelVisibility(VIEWER_PANELS.COMPARE, false);
 			this.props.resetCompareComponent();
 		}
+
+		const prevView = prevProps.selectedTicket?.properties?.[AdditionalProperties.DEFAULT_VIEW];
+		const currView = this.props.selectedTicket?.properties?.[AdditionalProperties.DEFAULT_VIEW];
+
+		if (!isEqual(prevView, currView)) {
+			// This is for not refreshing the view when exiting a selected ticket
+			goToView(currView);
+		}
 	}
 
 	public componentWillUnmount() {

frontend/src/v4/routes/viewerGui/viewerGui.container.ts

@@ -19,6 +19,7 @@ import { TeamspacesActions } from '@/v4/modules/teamspaces';
 import { connect } from 'react-redux';
 import { bindActionCreators } from 'redux';
 import { createStructuredSelector } from 'reselect';
+import { selectSelectedTicket } from '@/v5/store/tickets/card/ticketsCard.selectors';
 import { CompareActions } from '../../modules/compare';
 
 import { selectCurrentTeamspace, selectCurrentUser } from '../../modules/currentUser';
@@ -49,6 +50,7 @@ const mapStateToProps = createStructuredSelector({
 	isFocusMode: selectIsFocusMode,
 	disabledPanelButtons: selectDisabledPanelButtons,
 	isPresentationActive: selectIsPresentationActive,
+	selectedTicket: selectSelectedTicket,
 });
 
 export const mapDispatchToProps = (dispatch) => bindActionCreators({

frontend/src/v5/services/intl.ts

@@ -43,12 +43,19 @@ export const initializeIntl = (locale: string) => {
 			// Locale of the fallback defaultMessage
 			defaultLocale: DEFAULT_LOCALE,
 			messages,
+			onError: (error) => {
+				if (error.code === 'MISSING_TRANSLATION') {
+					return;
+				}
+		
+				console.error(error);
+			},
 		},
 		cache,
 	);
 };
 
-const getIntl = () => {
+export const getIntl = () => {
 	if (!intlInternal) {
 		initializeIntl(DEFAULT_LOCALE);
 	}
@@ -70,16 +77,3 @@ export const formatRelativeTime: typeof intlInternal.formatRelativeTime = (value
 
 // eslint-disable-next-line max-len
 export const formatPlural: typeof intlInternal.formatPlural = (value, opts?): Intl.LDMLPluralRule => getIntl().formatPlural(value, opts);
-
-export const getIntlProviderProps = () => ({
-	messages: getIntl().messages,
-	defaultLocal: getIntl().defaultLocale,
-	locale: getIntl().locale,
-	onError: (error) => {
-		if (error.code === 'MISSING_TRANSLATION' && getIntl().locale === DEFAULT_LOCALE) {
-			return;
-		}
-
-		console.error(error);
-	},
-});

frontend/src/v5/ui/routes/viewer/tickets/ticketsList/ticketsList.component.tsx

@@ -21,7 +21,6 @@ import { uniq, xor } from 'lodash';
 import { TicketsHooksSelectors, TicketsCardHooksSelectors } from '@/v5/services/selectorsHooks';
 import { TicketsActionsDispatchers, TicketsCardActionsDispatchers } from '@/v5/services/actionsDispatchers';
 import { FilterChip } from '@controls/chip/filterChip/filterChip.styles';
-import { goToView } from '@/v5/helpers/viewpoint.helpers';
 import { VIEWER_EVENTS } from '@/v4/constants/viewer';
 import { formatMessage } from '@/v5/services/intl';
 import { EmptyListMessage } from '@controls/dashedContainer/emptyListMessage/emptyListMessage.styles';
@@ -31,7 +30,6 @@ import { Viewer as ViewerService } from '@/v4/services/viewer/viewer';
 import { TicketItem } from './ticketItem/ticketItem.component';
 import { List, Filters, CompletedFilterChip } from './ticketsList.styles';
 import { ViewerParams } from '../../../routes.constants';
-import { AdditionalProperties } from '../tickets.constants';
 import { hasDefaultPin } from '../ticketsForm/properties/coordsProperty/coordsProperty.helpers';
 import { TicketSearchInput } from './ticketSearchInput/ticketSearchInput.component';
 
@@ -69,11 +67,6 @@ export const TicketsList = ({ tickets }: TicketsListProps) => {
 		TicketsActionsDispatchers.fetchTicketGroups(teamspace, project, containerOrFederation, ticket._id);
 	};
 
-	useEffect(() => {
-		const view = selectedTicket?.properties?.[AdditionalProperties.DEFAULT_VIEW];
-		goToView(view);
-	}, [selectedTicket?.properties?.[AdditionalProperties.DEFAULT_VIEW]]);
-
 	useEffect(() => {
 		TicketsCardActionsDispatchers.setSelectedTicketPin(selectedTicket?._id);