Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass revision Id to fetch ticket group information #4689

Closed
carmenfan opened this issue Jan 15, 2024 · 0 comments
Closed

Pass revision Id to fetch ticket group information #4689

carmenfan opened this issue Jan 15, 2024 · 0 comments

Comments

@carmenfan
Copy link
Member

carmenfan commented Jan 15, 2024

Description

This bug is found whilst testing #4552

In #4552 and #4641 we're storing IFC Guids/Revit Ids from metadata to represent the array of object, which will allow us to retain the grouping information across revision.

It is also discovered that this is an issue with smart groups in all branches.

The entry is then converted back to ids on an endpoint to get ticket group by id.

The issue is that the front end is currently not passing through the revision id along with the get ticket group request, thus the backend is assuming you want _ids from the latest revision. This obviously does not work when you are trying to view an older revision of the model.

The fix is just to append the revId or tag on the query string.

Steps to replicate

Situation 1

  • Upload an IFC or revit model twice (so you have 2 revisions)
  • On the older revision, create a smart group on a ticket

24-01-15 07-40-16

Situation 2

NOTE: this will require logic from #4641

  • Upload an IFC or revit model twice (so you have 2 revisions)
  • On the latest revision, Create a normal ticket group by selecting some objects
  • go to an older revision, try to view the ticket group

Current Behaviour

  • Corresponding objects are not coloured, inspecting the API request will see it is not passing the revision information to the endpoint, thus returning _ids from the latest revision

Expected Behaviour

  • corresponding objects should be coloured/hidden accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants