Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rems unit from v5 #5401

Open
3 tasks
Amantini1997 opened this issue Feb 12, 2025 · 0 comments
Open
3 tasks

Remove rems unit from v5 #5401

Amantini1997 opened this issue Feb 12, 2025 · 0 comments

Comments

@Amantini1997
Copy link
Contributor

Description

Everywhere across the app we use px as unit to define components outlook.
However, in theme, we use rems for font-size and line-height.
It would be nice to use the same unit everywhere

Suggested solution

Refactor theme and convert rems to pxs values

Goal

  • Use a consistent approach for units
  • Keep the more intuitive unit only to make it simpler to work with

Tasks

  • Refactor the theme file (and any other v5 files if any) to only use px
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant