-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onPRClose action can only destroy deployments following issue-xxx format #5403
Comments
The PR should have data about the branch we're merging from so we should 100% do that instead of guessing Note we should only do it for the deployment not the branch itself, destruction of the branch should be manged by github there's automation setup to auto delete a branch upon merge |
Helm chart names should not have uppercase/underscores: https://helm.sh/docs/chart_best_practices/conventions/ |
Description
onPRClose.yml
expects all issues to follow theisssue-xxx
format wherexxx
is the issue number: https://github.com/3drepo/3drepo.io/blob/master/.github/workflows/onPRClose.ymlThis will need to change if we have branches that don't follow the format, e.g. qa, issue-123b, etc..
Suggested solution
Goal
isssue-xxx
branches as beforeTasks
The text was updated successfully, but these errors were encountered: