Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onPRClose action can only destroy deployments following issue-xxx format #5403

Open
Charence opened this issue Feb 13, 2025 · 3 comments
Open

Comments

@Charence
Copy link
Contributor

Description

onPRClose.yml expects all issues to follow the isssue-xxx format where xxx is the issue number: https://github.com/3drepo/3drepo.io/blob/master/.github/workflows/onPRClose.yml

This will need to change if we have branches that don't follow the format, e.g. qa, issue-123b, etc..

Suggested solution

  • Use branch name instead of recreating from issue number to destroy deployment
  • Otherwise, accept manual intervention required to remove those branches

Goal

  • Destroy isssue-xxx branches as before
  • Destroy other branches that don't following that naming format, e.g. qa, issue-123b, etc.

Tasks

@carmenfan
Copy link
Member

carmenfan commented Feb 13, 2025

Use branch name instead of recreating from issue number to destroy deployment

The PR should have data about the branch we're merging from so we should 100% do that instead of guessing

Note we should only do it for the deployment not the branch itself, destruction of the branch should be manged by github there's automation setup to auto delete a branch upon merge

@Charence
Copy link
Contributor Author

@Charence
Copy link
Contributor Author

Helm chart names should not have uppercase/underscores: https://helm.sh/docs/chart_best_practices/conventions/

Charence added a commit that referenced this issue Feb 14, 2025
Charence added a commit that referenced this issue Feb 14, 2025
Charence added a commit that referenced this issue Feb 14, 2025
Charence added a commit that referenced this issue Feb 14, 2025
Charence added a commit that referenced this issue Feb 14, 2025
Charence added a commit that referenced this issue Feb 14, 2025
Charence added a commit that referenced this issue Feb 14, 2025
Charence added a commit that referenced this issue Feb 14, 2025
Charence added a commit that referenced this issue Feb 14, 2025
Charence added a commit that referenced this issue Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants