Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace device library with an alternative #5427

Open
carmenfan opened this issue Feb 25, 2025 · 3 comments
Open

Replace device library with an alternative #5427

carmenfan opened this issue Feb 25, 2025 · 3 comments
Assignees

Comments

@carmenfan
Copy link
Member

Description

We're using device library to determine what is the device used by the user logging in through the useragent. This seems to be an abandoned project (last updated 5 years ago), and it has a dependecy on useragent which is another abandoned project that we've replaced in #5239.

Suggested solution

We want to use something that is more up to date to make sure we're protected against vunerability and provide us with up to date results, a quick google points me to https://www.npmjs.com/package/node-device-detector but there may be other options too.

Goal

  • To replace an old, unmaintained device detection library with something more recent/actively maintained
  • Device detection should still function as before (if not better!)

Tasks

TBC by the developer

@jacobcons
Copy link

@carmenfan I'd be happy to work on this 😊

@carmenfan
Copy link
Member Author

carmenfan commented Mar 6, 2025

Hi @jacobcons

This is a piece of work I carved out for an internal member to keep them busy whilst I sort out other things. Thank you for offering though!

@jacobcons
Copy link

@carmenfan No worries at all! I updated this pr #5390 to have full test coverage btw. Would love to get your thoughts when you have a chance, no worries if things are very busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants