Docker - Fix the dev image for building ZIP, do not use ; when the previous command must success

Author: Gustry

Makefile

@@ -1,6 +1,6 @@
 #
-# expected variables in the CI environment
-# - REGISTRY_URL = url of the docker registry
+# Expected variables in the CI environment
+# - REGISTRY_URL = URL of the Docker registry
 
 STAGE=build
 

dev/Dockerfile

@@ -6,16 +6,18 @@ ARG php_version
 ARG DEBIAN_FRONTEND=noninteractive
 ENV PHP_VERSION=${php_version}
 
-RUN export DEBIAN_FRONTEND=noninteractive && apt-get install -y --no-install-recommends \
+RUN export DEBIAN_FRONTEND=noninteractive \
+    && apt-get update \
+    && apt-get install -y --no-install-recommends \
         make \
         git \
         zip \
-    ; apt-get clean
+    && apt-get clean
 
 # Install nodejs and npm to build js files
 RUN apt-get install -y ca-certificates curl gnupg \
     && mkdir -p /etc/apt/keyrings \
     && curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg \
-    && echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_18.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list \
+    && echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_21.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list \
     && apt-get update \
     && apt-get install nodejs -y

docker/Dockerfile

@@ -1,5 +1,5 @@
 ARG REGISTRY_PREFIX=''
-FROM ${REGISTRY_PREFIX}alpine:3.17 as build
+FROM ${REGISTRY_PREFIX}alpine:3.17 AS build
 
 COPY lizmap_web_client.zip .
 RUN unzip lizmap_web_client.zip

docker/README.md

@@ -1,8 +1,7 @@
 # Lizmap web client Docker image
 
 The container deploys one Lizmap instance and may run php-fpm on the command line.
-(see [docker/php](https://hub.docker.com/_/php/) )
-
+(see [docker/php](https://hub.docker.com/_/php/))
 
 ## Configuration variables