Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newer version of K8S Controller Runtime API breaks the basereconciler #14

Open
kkasbi opened this issue Mar 14, 2024 · 4 comments
Open

Newer version of K8S Controller Runtime API breaks the basereconciler #14

kkasbi opened this issue Mar 14, 2024 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one.

Comments

@kkasbi
Copy link

kkasbi commented Mar 14, 2024 •
edited
Loading

I am trying to use the basereconciler with a newer operator, but when I build it, this is the error I get.
CleanShot 2024-03-14 at 17 56 17@2x

Also, Just to confirm, I tried updating an old operator which used the earlier version of Kubernetes Controller-Runtime version to the latest, it also started failing.
@3scale-robot 3scale-robot added needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Mar 14, 2024
@kkasbi
Copy link
Author

kkasbi commented Mar 14, 2024

/kind bug

@3scale-robot 3scale-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. labels Mar 14, 2024
@roivaz
Copy link
Member

roivaz commented Mar 14, 2024

Hi @kkasbi which version of controller-runtime are you using? The latest release of basereconciler uses sigs.k8s.io/controller-runtime v0.14.5.

@kkasbi
Copy link
Author

kkasbi commented Mar 14, 2024

@roivaz I am using this one.
I created a new controller using the operator SDK and it is by default forcing me for the latest version.
sigs.k8s.io/controller-runtime v0.17.2

@roivaz
Copy link
Member

roivaz commented Mar 15, 2024

@kkasbi the problem is that there are several breaking changes between controller-runtime 0.15 and 0.17 that make basereconciler when you try to use it on a new project with controller-runtime v0.17. I'm working on a PR to upgrade controller-runtime to the latest version, see #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roivaz @3scale-robot @kkasbi