Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoouyeon
reviewed
Oct 20, 2023
| import { React } from 'react'; | ||
| import NavBar from './NavBar'; | ||
| import SideBar from './SideBar'; | ||
| import PropTypes from 'prop-types'; |
There was a problem hiding this comment.
PropTypes 이용해서 js에서도 타입체킹을 할 수 있네요..! 배워갑니다 👍
There was a problem hiding this comment.
@yoouyeon eslint가 강제하는 바람에 하게 됬네요ㅋㅋ
Comment on lines
+11
to
+13
| if (!userStateValue.isLoggedIn && normal) { | ||
| return <Navigate to="/login" replace={true} />; | ||
| } |
There was a problem hiding this comment.
의도하신건지는 모르겠지만 로그인 상태가 아닐 때 /manage 같은 normal 권한이 아닌 페이지에 접근했을 때에는 로그인 페이지가 아니라 아래 14번째 줄의 조건문으로 들어가네요!
로그인 상태가 아닐 때 normal, manager, admin 권한 중 하나라도 있으면 로그인 페이지로 이동시키는 방식으로 한다면 로그아웃 상태의 유저를 통일성있게 처리할 수 있을 것 같습니당
There was a problem hiding this comment.
@yoouyeon 의도한 것이긴 합니다! 이렇게 하는게 보안상의 의미가 있는지는 모르겠지만, 외부에서 매니저 페이지 혹은 관리자 페이지의 url을 알지 못 하게 하고 싶었습니다😅
hyobb109
reviewed
Oct 20, 2023
| import userState from '../userState'; | ||
| import PageNotFound from '../pages/PageNotFound'; | ||
|
|
||
| export default function ProtectedRoute({ normal, manager, admin }) { |
There was a problem hiding this comment.
이 부분에서 prop이름이 로그인된 유저의 권한인지, 페이지인지 헷갈려서 normalPage 이런 식으로 좀 더 명확하게 해주면 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2주차 결과물입니다.
일반 유저
id : jincpark
password : 1q2w3e4r
매니저
id: banana
password: bananaisyellow
관리자
id: apple
password: appleisred