Skip to content

Commit 751abec

Browse files
committed
fix(cs): warnings
1 parent bec6761 commit 751abec

9 files changed

Lines changed: 13 additions & 3 deletions

File tree

hosts/dotnet/Hako/Builders/ModuleLoaderBuilder.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
using HakoJS.Exceptions;
12
using HakoJS.Extensions;
23
using HakoJS.Host;
34
using HakoJS.SourceGeneration;

hosts/dotnet/Hako/Extensions/CollectionExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public static class CollectionExtensions
2020
/// <remarks>
2121
/// <para>
2222
/// This method handles primitive types only. For custom types implementing <see cref="IJSMarshalable{T}" />,
23-
/// use <see cref="ToJSArrayOf{T}" /> instead.
23+
/// use <see cref="JSValueExtensions.ToArrayOf{T}" /> instead.
2424
/// </para>
2525
/// <para>
2626
/// Example:

hosts/dotnet/Hako/Host/CModule.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using HakoJS.Exceptions;
2+
using HakoJS.Extensions;
23
using HakoJS.VM;
34

45
namespace HakoJS.Host;
@@ -160,7 +161,7 @@ public void Dispose()
160161

161162
_createdClasses.Clear();
162163

163-
Context.Runtime.Callbacks.UnregisterModuleInitHandler(Name);
164+
if (Name != null) Context.Runtime.Callbacks.UnregisterModuleInitHandler(Name);
164165
_disposed = true;
165166
}
166167

hosts/dotnet/Hako/VM/JSAsyncIterator.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
using HakoJS.Extensions;
12
using HakoJS.Host;
23
using HakoJS.Lifetime;
34

hosts/dotnet/Hako/VM/JSClass.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
using HakoJS.Builders;
12
using HakoJS.Exceptions;
23
using HakoJS.Host;
34

hosts/dotnet/Hako/VM/JSIterator.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System.Collections;
2+
using HakoJS.Extensions;
23
using HakoJS.Host;
34
using HakoJS.Lifetime;
45

hosts/dotnet/Hako/VM/JSObject.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
using HakoJS.Exceptions;
2+
13
namespace HakoJS.VM;
24

35
/// <summary>
@@ -56,7 +58,7 @@ public void Dispose()
5658
if (_disposed)
5759
return;
5860

59-
_value?.Dispose();
61+
_value.Dispose();
6062
_disposed = true;
6163
}
6264

hosts/dotnet/Hako/VM/Realm.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using System.Text.Json;
22
using HakoJS.Exceptions;
3+
using HakoJS.Extensions;
34
using HakoJS.Host;
45
using HakoJS.Lifetime;
56
using HakoJS.SourceGeneration;

hosts/dotnet/Hako/VM/RealmEvalOptions.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
using HakoJS.Extensions;
2+
13
namespace HakoJS.VM;
24

35
/// <summary>

0 commit comments

Comments
 (0)