Refactor code for improved readability and consistency in models and services

Author: AAdewunmi

policylens/apps/claims/models.py

@@ -96,7 +96,7 @@ def __str__(self) -> str:
         return f"Claim:{self.pk} {self.status}"
 
 
-def claim_document_upload_to(instance: "ClaimDocument", filename: str) -> str:
+def claim_document_upload_to(instance: ClaimDocument, filename: str) -> str:
     """Return a deterministic upload path for claim documents."""
     # Avoid embedding the original filename in the directory structure.
     return f"claim_docs/claim_{instance.claim_id}/{filename}"

policylens/apps/claims/services.py

@@ -30,7 +30,9 @@ class DomainRuleViolation(Exception):
     """
 
 
-def append_audit_event(*, claim: Claim, event_type: str, actor: str, payload: dict[str, Any]) -> AuditEvent:
+def append_audit_event(
+    *, claim: Claim, event_type: str, actor: str, payload: dict[str, Any]
+) -> AuditEvent:
     """Append an audit event for a claim."""
     return AuditEvent.objects.create(
         claim=claim,
@@ -75,7 +77,9 @@ def create_claim(
 def _assert_claim_not_decided(*, claim: Claim) -> None:
     """Prevent mutations that should not happen after a final decision."""
     if claim.status == Claim.Status.DECIDED:
-        raise DomainRuleViolation("Claim is already decided. No further workflow actions are allowed.")
+        raise DomainRuleViolation(
+            "Claim is already decided. No further workflow actions are allowed."
+        )
 
 
 @transaction.atomic
@@ -120,7 +124,11 @@ def add_note(*, claim: Claim, body: str, actor: str) -> InternalNote:
     if not body or not body.strip():
         raise DomainRuleViolation("Note body is required.")
 
-    note = InternalNote.objects.create(claim=claim, body=body.strip(), created_by=actor)
+    note = InternalNote.objects.create(
+        claim=claim,
+        body=body.strip(),
+        created_by=actor,
+    )
 
     append_audit_event(
         claim=claim,

policylens/config/settings.py

@@ -25,15 +25,11 @@
 
 SECRET_KEY = env("DJANGO_SECRET_KEY")
 if not SECRET_KEY:
-    raise RuntimeError(
-        "DJANGO_SECRET_KEY is required. Set it in .env "
-        "or environment variables."
-    )
+    raise RuntimeError("DJANGO_SECRET_KEY is required. Set it in .env or environment variables.")
 
 DEBUG = env("DJANGO_DEBUG")
 
-ALLOWED_HOSTS = [h.strip()
-                 for h in env("DJANGO_ALLOWED_HOSTS").split(",") if h.strip()]
+ALLOWED_HOSTS = [h.strip() for h in env("DJANGO_ALLOWED_HOSTS").split(",") if h.strip()]
 
 INSTALLED_APPS = [
     "django.contrib.admin",
@@ -86,30 +82,10 @@
 DATABASES["default"]["CONN_MAX_AGE"] = 60
 
 AUTH_PASSWORD_VALIDATORS = [
-    {
-        "NAME": (
-            "django.contrib.auth.password_validation."
-            "UserAttributeSimilarityValidator"
-        ),
-    },
-    {
-        "NAME": (
-            "django.contrib.auth.password_validation."
-            "MinimumLengthValidator"
-        ),
-    },
-    {
-        "NAME": (
-            "django.contrib.auth.password_validation."
-            "CommonPasswordValidator"
-        ),
-    },
-    {
-        "NAME": (
-            "django.contrib.auth.password_validation."
-            "NumericPasswordValidator"
-        ),
-    },
+    {"NAME": "django.contrib.auth.password_validation.UserAttributeSimilarityValidator"},
+    {"NAME": "django.contrib.auth.password_validation.MinimumLengthValidator"},
+    {"NAME": "django.contrib.auth.password_validation.CommonPasswordValidator"},
+    {"NAME": "django.contrib.auth.password_validation.NumericPasswordValidator"},
 ]
 
 LANGUAGE_CODE = "en-gb"