-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some way to version this model from within the spack.yaml
#3
Comments
spack.yaml
- should we get this from access-om3
spack package? From the COSIMA/access-om3
repository? Do we continue with the calver-minor
format that we have for ACCESS-OM2
? How do we reconcile the versioning of COSIMA/access-om3
with our own one?spack.yaml
Just for our discussion tomorrow :) |
So we had a resolution with @aidanheerdegen and @harshula s help!
All in favour, say 'Aye!' |
Aye aye! ☠️ 🏴☠️ Possible naming conventions:
|
Just trying to understand a bit the context and the issue. From what is written above I deduce that the version number of the releases in https://github.com/ACCESS-NRI/access-om3 need to be identical to the version of OM3 you are releasing. Is this correct? If so, why is that? Is it because this is an assumption built in the CI/CD? Otherwise I would have just expected that releases in https://github.com/ACCESS-NRI/access-om3 can be whatever you want, as long as there is a one-to-one mapping between them and the version of OM3. Edit: to put it in another way. Why can't you simply pin the version of OM3 here? Edit 2: thinking further about this, the mapping between the NRI release and the version of OM3 should not be bijective. The only requirement is that to each NRI release corresponds only one version of OM3, which is trivial. |
Hey Micael! :)
No - it's the opposite case we need.
We will be. But the overall version of the deployed release is more than just the version of So we will need to have a SBD that can act as this 'overall' version. |
Okay, I understand that you want to version the whole deployment. I just assumed that was the version of https://github.com/ACCESS-NRI/access-om3 So the issue is simply that you want to have a version number corresponding to the whole deployment in the spack.yaml itself? |
Correct! The current thinking is that we use a SBD (as we did in ACCESS-OM2) to be this overall version. That way we can still pick out the versions |
Sorry, I'm not sure I understand this bit. Why do you need an SBD to specify the dependencies' versions? These are already defined in the |
Ah, correct. Got my wires a little crossed there - the spack.yaml was what I meant. Sorry! |
Closed as we have a way forward with this issue. Continuing updates will be in #5 |
We are using
YYYY.0M.MINOR
to version ourspack
deployments. TheCOSIMA/access-om3
repo uses a different versioning scheme for their model and their spack package. How do we version our spack deployments, and where can we put this information?How do we reconcile the versioning of
COSIMA/access-om3
with our own one?The text was updated successfully, but these errors were encountered: