Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preindustrial: add basin mask for basin specific diagnostics #101

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

blimlim
Copy link

@blimlim blimlim commented Nov 18, 2024

Closes the preindustrial half of #95.

This PR sets MOM to read the basin_mask.nc input file which allows for basin specific tracer diagnostics (e.g. temp_merid_flux_over_atlantic) to be saved.

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if things were just straightforward.

Any ideas?

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working through the unrelated difficulties.

@blimlim blimlim merged commit 31e9602 into dev-preindustrial+concentrations Nov 20, 2024
10 checks passed
@blimlim
Copy link
Author

blimlim commented Nov 20, 2024

Awesome, thanks @CodeGat and @aidanheerdegen for sorting that out!

@blimlim blimlim deleted the 95-add-basin-mask-PI branch November 20, 2024 22:36
@access-hive-bot
Copy link

This pull request has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/access-esm1-5-release-information/2352/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants