Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI config #193

Closed
anton-seaice opened this issue Feb 25, 2025 · 4 comments · Fixed by #194 or #210
Closed

Update CI config #193

anton-seaice opened this issue Feb 25, 2025 · 4 comments · Fixed by #194 or #210

Comments

@anton-seaice
Copy link
Contributor

There are several useful changes implemented / underway which we should update config.yaml to use:

ACCESS-NRI/model-config-tests#111 : allows using regex matching in branch names, e.g.

"qa": {
        "dev-.*": { 
            "markers": "dev_config"
        },
        "default": {
           "markers": "config or dev_config"
       }
   },

ACCESS-NRI/model-config-tests#113 : allows using the main branch of model-config-tests. We should set dev branches to use main branch and release branches to use a release version

ACCESS-NRI/model-config-tests#110 : fixes restart repro

ACCESS-NRI/model-config-tests#103 : added the dev_config marker

@anton-seaice
Copy link
Contributor Author

Reopening so we can fix the regex syntax - per ACCESS-NRI/model-config-tests#118 (comment)

@jo-basevi
Copy link
Contributor

Now with ACCESS-NRI/model-config-tests#126 which prevents running scheduled tests on any branch/tag that does not exist in the repository, it should be possible to include regex under scheduled tests. Note that regex currently only be used for getting common testing configuration such as payu-version - it won't trigger scheduled tests for every release branch. So for the following config/ci.json:

"scheduled": {
        "default": {
            "markers": "checksum or checksum_slow or access_om3 or config"
        },
        "dev-1deg_jra55do_ryf": {
            "markers": "checksum or checksum_slow or access_om3 or dev_config"
        },
        "release-1deg_jra55do_ryf": {},
        "release-.*": {
            "model-config-tests-version": "0.0.12",
            "payu-version": "1.1.6"
        }
#...

The only scheduled test will run would be dev-1deg_jra55do_ryf. When release-1deg_jra55do_ryf exists in the repository, it will also trigger a scheduled test, and it will fall back to release-.* and default for the pytest configuration.

@anton-seaice
Copy link
Contributor Author

When release-1deg_jra55do_ryf exists in the repository

If we add this to the ci.json now, will this test fail? Or not run ?

@jo-basevi
Copy link
Contributor

It will not run a scheduled test for release-1deg_jra55do_ryf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants