Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment Comment spack Environment Name Not Filled In #146

Closed
CodeGat opened this issue Oct 18, 2024 · 0 comments · Fixed by #176
Closed

Deployment Comment spack Environment Name Not Filled In #146

CodeGat opened this issue Oct 18, 2024 · 0 comments · Fixed by #176
Labels
priority:low type:bug

Comments

@CodeGat
Copy link
Member

CodeGat commented Oct 18, 2024

See ACCESS-NRI/ACCESS-ESM1.5#14 (comment), specifically in the Details and usage instructions section.

This line:

This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p5- environment.

should be:

This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-esm1p5-pr14-3 environment.

This is probably due to referencing an incorrect template variable.
CodeGat added a commit that referenced this issue Nov 25, 2024
@CodeGat
ci.yml: Updated deployment comment prerelease version templating, ref…
bd59c5a 
…erences #146
@CodeGat CodeGat mentioned this issue Nov 25, 2024
Merged
CodeGat added a commit that referenced this issue Dec 3, 2024
@CodeGat
ci.yml: Updated deployment comment prerelease version templating, ref…
c63e605 
…erences #146
CodeGat added a commit that referenced this issue Dec 10, 2024
@CodeGat
Add !redeploy Comment Command (#176)
68b231f 
* ci.yml: Updated deployment comment prerelease version templating, references #146

* ci.yml: Added new required input `pr`, set pr metadata in `defaults` job

* ci.yml: Explicitly clone all repos at `inputs.pr`, replace all `github.*` contexts with `inputs.pr`/`needs.default.outputs.*`

* ci.yml: Comment clean up

* validate-repo-version: Added new required input `pr`, updated references in `ci.yml`

* ci.yml: Added redeploy logic

This stops the `workflow_call` limitation mentioned in the PR

* ci.yml: Redeploy is now branch deployments + redeploy deployments

Removed ci-comment pr inputs

* ci.yml: Added permissions check to `redeploy-pre` job

* ci.yml: Add in warning about updating the minimum permissions for redeploy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:low type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add !redeploy Comment Command ACCESS-NRI/build-cd
1 participant
@CodeGat