Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GitHub Environments More Consistent #220

Closed
CodeGat opened this issue Feb 3, 2025 · 3 comments
Closed

Make GitHub Environments More Consistent #220

CodeGat opened this issue Feb 3, 2025 · 3 comments
Assignees
@CodeGat
Labels
for:v4 Applies to `v4` priority:medium type:enhancement Improvements to existing features version:MAJOR Requires an update to Model Deployment Repositories CI

Comments

@CodeGat
Copy link
Member

CodeGat commented Feb 3, 2025 •
edited
Loading

See #218 (comment) (thanks, @aidanheerdegen!)

Currently, we don't give any type-specifier for Release GitHub Environments. This makes the logic in the CI a bit more convoluted.

For v4, we are looking to require the Release type on all Release GitHub Environments. So, the changes would be:

Type Old Environment Name (v3) New Environment Name (v4)
Prerelease SUPERCOMPUTER Prerelease SUPERCOMPUTER Prerelease
Release SUPERCOMPUTER SUPERCOMPUTER Release

This requires changes to model-deployment-template instructions, build-cd (for environment name resolution) and all deployment repositories that move to v4.
@CodeGat CodeGat added for:v4 Applies to `v4` priority:medium type:enhancement Improvements to existing features version:MAJOR Requires an update to Model Deployment Repositories CI labels Feb 3, 2025
@CodeGat CodeGat self-assigned this Feb 3, 2025
@github-project-automation github-project-automation bot moved this to New Issues 🌅 in Model Release Feb 3, 2025
@aidanheerdegen
Copy link
Member

Ugh. Sorry for all the work, but I think it is worth it.

@CodeGat
Copy link
Member Author

CodeGat commented Feb 3, 2025

It's good to standardize!

@CodeGat CodeGat mentioned this issue Feb 3, 2025
Merged
@CodeGat CodeGat moved this from New Issues 🌅 to Review 👏 in Model Release Feb 3, 2025
This was referenced Feb 3, 2025
Merged
Merged
@CodeGat
Copy link
Member Author

CodeGat commented Feb 3, 2025

Closed via #221

@CodeGat CodeGat closed this as completed Feb 3, 2025
@github-project-automation github-project-automation bot moved this from Review 👏 to Done ✅ in Model Release Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CodeGat CodeGat

Labels
for:v4 Applies to `v4` priority:medium type:enhancement Improvements to existing features version:MAJOR Requires an update to Model Deployment Repositories CI
Projects
Model Release
Status: Done ✅
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aidanheerdegen @CodeGat