Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove schema checks on Draft #237

Closed
CodeGat opened this issue Mar 6, 2025 · 0 comments · Fixed by #244
Closed

Remove schema checks on Draft #237

CodeGat opened this issue Mar 6, 2025 · 0 comments · Fixed by #244
Assignees
Labels
for:v4 Applies to `v4` priority:high type:enhancement Improvements to existing features version:MINOR Doesn't require update to Model Deployment Repositories

Comments

@CodeGat
Copy link
Member

CodeGat commented Mar 6, 2025

Background

The restrictive schema has been in place for Prereleases as the original rationale was that Prereleases were a natural testing ground for eventual Releases.

This has evolved slightly, with developers using Prereleases as sharable testing grounds with no intention of merging them, making the schema unnessecarily restrictive.

There have been other pull requests to build-cd that have weakened the restrictions on the schema (such as #235 and ACCESS-NRI/schema#45) or removed restrictions on Draft PRs (such as #226).

As a logical next step, we are looking to remove all schema restrictions on Draft PRs, giving developers the flexibility to test what they want, if there is no intention to make it a Release.

Implementation Details

  • Make check-spack-yaml job conditional on the draft status of the PR.
    • Decide if we still need to do the modulefile dependency checks for Draft PRs.
  • Determine how comments will look for draft PRs - there is a possibilty that there is no longer a spack.specs[0]/spack.definitions.ROOT_PACKAGE[0].

Thanks @harshula for the suggestion. Pinging @anton-seaice and @dougiesquire so they know when this is done.

@CodeGat CodeGat added for:v4 Applies to `v4` priority:high type:enhancement Improvements to existing features version:MINOR Doesn't require update to Model Deployment Repositories labels Mar 6, 2025
@CodeGat CodeGat self-assigned this Mar 6, 2025
@github-project-automation github-project-automation bot moved this to New Issues 🌅 in Model Release Mar 6, 2025
@CodeGat CodeGat moved this from New Issues 🌅 to In Progress 🏗️ in Model Release Mar 6, 2025
@CodeGat CodeGat linked a pull request Mar 7, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress 🏗️ to Done ✅ in Model Release Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for:v4 Applies to `v4` priority:high type:enhancement Improvements to existing features version:MINOR Doesn't require update to Model Deployment Repositories
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

1 participant