Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun deployment once on.converted_to_draft PRs are on.ready_for_review #238

Open
CodeGat opened this issue Mar 6, 2025 · 1 comment
Open
Assignees
Labels
for:v5 Applies to `v5` priority:low type:enhancement Improvements to existing features version:MAJOR Requires an update to Model Deployment Repositories CI

Comments

@CodeGat
Copy link
Member

CodeGat commented Mar 6, 2025

Background

We currently loosen restrictions on Draft PRs as they have no intention of being merged. However, there is an edge case where a draft PR is committed to, passes the loosened restrictions, then converts to Ready For Review. There is a possibility that this is approved and then is merged, which would then later fail the Release Deployment Checks. This would lead to a revert operation in which we must delete the created tag, reset main to HEAD~1, and reopen the merged PR again.

If we require a deployment on.ready_for_review, we would at least see in the checks that there was a failure using the more restrictive checks, if we were looking to merge this into a Release.

Thanks @aidanheerdegen for the suggestion!

@CodeGat CodeGat added for:v5 Applies to `v5` priority:low type:enhancement Improvements to existing features version:MAJOR Requires an update to Model Deployment Repositories CI labels Mar 6, 2025
@CodeGat CodeGat self-assigned this Mar 6, 2025
@github-project-automation github-project-automation bot moved this to New Issues 🌅 in Model Release Mar 6, 2025
@CodeGat
Copy link
Member Author

CodeGat commented Mar 6, 2025

We would probably hope to bundle this relatively small change in with a larger version:MAJOR change, to lessen the burden on model-deployment repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for:v5 Applies to `v5` priority:low type:enhancement Improvements to existing features version:MAJOR Requires an update to Model Deployment Repositories CI
Projects
Status: New Issues 🌅
Development

No branches or pull requests

1 participant