Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payu setup check? #9

Open
aidanheerdegen opened this issue Apr 11, 2024 · 3 comments
Open

Add payu setup check? #9

aidanheerdegen opened this issue Apr 11, 2024 · 3 comments
Labels
priority:medium type:qa-check Quality Assurance Checks

Comments

@aidanheerdegen
Copy link
Member

We could add payu setup check to the QA workflow.

This would be relatively quick to run and would be a sanity check for correct paths on deployment targets (gadi).

@aidanheerdegen aidanheerdegen transferred this issue from ACCESS-NRI/access-om2-configs May 3, 2024
@aidanheerdegen aidanheerdegen added priority:medium type:qa-check Quality Assurance Checks labels May 6, 2024
@jo-basevi
Copy link
Collaborator

Once payu setup is run, it can be used to check the manifests are unchanged (e.g. manifests/input.yaml, manifests/restart.yaml and manifests/exe.yaml).

The QA checks currently just run on Github Runners, while this sort of these would require a logging in to the deployment target. Should there be two different types of QA checks for local and remote? It could almost go under the reproducibility tests that log onto Github runners?

@anton-seaice
Copy link
Contributor

to check the manifests are unchanged

I would find this useful.

I agree, it makes sense to write into the repro test rather than the QA check.

@aidanheerdegen
Copy link
Member Author

The QA checks currently just run on Github Runners, while this sort of these would require a logging in to the deployment target.

Now that we have the model-config-inputs repo which should have an up-to-date manifest of all the model inputs, we should be able to this check on a GitHub runner.

Should there be two different types of QA checks for local and remote? It could almost go under the reproducibility tests that log onto Github runners?

See above, but that also doesn't mean we could do a payu setup sanity check as part of the repro checks to make sure they're consistent. There may well be other QA checks we can't do on a runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium type:qa-check Quality Assurance Checks
Projects
None yet
Development

No branches or pull requests

3 participants