From 466f83c9965d66dc7ad2530ebf8d89339ca7e1a8 Mon Sep 17 00:00:00 2001
From: dpad85 <5765435+dpad85@users.noreply.github.com>
Date: Fri, 24 Jan 2020 16:00:25 +0100
Subject: [PATCH 1/3] Upgrade to eclair 0.3.6-android-phoenix
---
app/build.gradle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/build.gradle b/app/build.gradle
index 776b1c684..68ffed392 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -132,7 +132,7 @@ dependencies {
// eclair core
def libsecp256k1_version = "1.3"
- def eclair_version = "0.3.6-android-phoenix-RC1"
+ def eclair_version = "0.3.6-android-phoenix"
implementation "fr.acinq.bitcoin:secp256k1-jni:$libsecp256k1_version"
implementation("fr.acinq.eclair:eclair-core_2.11:$eclair_version") {
exclude group: 'fr.acinq.bitcoin', module: 'secp256k1-jni'
From 832efd6de89ac48ac9b2b2839de8619a5593dd3a Mon Sep 17 00:00:00 2001
From: dpad85 <5765435+dpad85@users.noreply.github.com>
Date: Fri, 24 Jan 2020 16:02:48 +0100
Subject: [PATCH 2/3] Upgrade material component lib to latest
---
app/build.gradle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/build.gradle b/app/build.gradle
index 68ffed392..72fc88f80 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -94,7 +94,7 @@ dependencies {
implementation "androidx.appcompat:appcompat:1.1.0"
// ANDROIDX - material
- def material_version = "1.2.0-alpha03"
+ def material_version = "1.2.0-alpha04"
implementation "com.google.android.material:material:$material_version"
// ANDROIDX - navigation
From 97fd05523241107c2886f4f4b95f99738b78bb9f Mon Sep 17 00:00:00 2001
From: dpad85 <5765435+dpad85@users.noreply.github.com>
Date: Fri, 24 Jan 2020 16:14:41 +0100
Subject: [PATCH 3/3] Add error if payment is expired
---
app/src/main/java/fr/acinq/phoenix/send/ReadInputFragment.kt | 3 +++
app/src/main/res/values/strings.xml | 1 +
2 files changed, 4 insertions(+)
diff --git a/app/src/main/java/fr/acinq/phoenix/send/ReadInputFragment.kt b/app/src/main/java/fr/acinq/phoenix/send/ReadInputFragment.kt
index 229a763b5..668edcc29 100644
--- a/app/src/main/java/fr/acinq/phoenix/send/ReadInputFragment.kt
+++ b/app/src/main/java/fr/acinq/phoenix/send/ReadInputFragment.kt
@@ -76,6 +76,9 @@ class ReadInputFragment : BaseFragment() {
log.debug("abort payment to self")
model.readingState.postValue(ReadingState.ERROR)
model.errorMessage.postValue(R.string.scan_error_pay_to_self)
+ } else if (it.isExpired) {
+ model.readingState.postValue(ReadingState.ERROR)
+ model.errorMessage.postValue(R.string.scan_error_expired)
} else if (it.amount().isEmpty && !it.features().allowTrampoline()) {
// Payment request is pre-trampoline and SHOULD specify an amount. Show warning to user.
AlertHelper.build(layoutInflater, Converter.html(getString(R.string.scan_amountless_legacy_title)), Converter.html(getString(R.string.scan_amountless_legacy_message)))
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index a02355c6a..224f15ab9 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -165,6 +165,7 @@
Reading payment request
This is not a valid payment request.\n\nPlease try again.
+ Payment has expired.
You cannot pay yourself.
This invoice does not use the same blockchain as your wallet.
This LNURL is not supported yet!