Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GNAF class relations #19

Open
dr-shorthair opened this issue Mar 25, 2020 · 9 comments · May be fixed by #20
Open

Fix GNAF class relations #19

dr-shorthair opened this issue Mar 25, 2020 · 9 comments · May be fixed by #20
Assignees

Comments

@dr-shorthair
Copy link

  1. Since not every individual geo:Geometry is a GnafEntity then the sub-class relationship is incorrect.
@dr-shorthair
Copy link
Author

dr-shorthair commented Mar 25, 2020

  1. GnafEntity is a spatial-object (feature or geometry) which has some lifecycle information (created, retired) and a mandatory identifier. Should be sub-class-of geo:SpatialObject?

@dr-shorthair
Copy link
Author

  1. Several GNAF classes correspond to ASGS classes, but with the additional requirements of a GnafEntity. These should be sub-classes of GnafEntity also with equivalent-class relationships with the ASGS classes recorded somewhere. (maybe in a separate graph).
  • gnaf:State equivalent to asgs:StateOrTerritory
  • gnaf:MB_2011 and gnaf:MB_2016 sub-classes of gnaf:MeshBlock equivalent to asgs:MeshBlock

@dr-shorthair
Copy link
Author

  1. No - some GnafEntity sub-classes are not spatial-objects (AddressSite, MeshblockMatch, Alias).

@dr-shorthair
Copy link
Author

  1. Separate graph is in gnaf-asgs.ttl

@dr-shorthair
Copy link
Author

dr-shorthair commented Mar 26, 2020

  1. There is not actually a STREET class in the G-NAF product description, only STREET_LOCALITY. I don't understand why there is one in gnaf-ont ...

@dr-shorthair
Copy link
Author

  1. Propose making gnaf:StreetLocality the principle class in gnaf-ont - sub-class of geo:Feature and gnaf:GnafEntity. Not quite sure what gnaf:Street does

@dr-shorthair
Copy link
Author

dr-shorthair commented Mar 29, 2020

related to: #8

@nicholascar
Copy link
Member

I remember these Street class issues, a couple of years ago now! No answers I’m afraid only I agree with your characterisation of the situation

@dr-shorthair
Copy link
Author

My hunch is that you guys wanted a general 'Street' class to aggregate all the sections represented as StreetLocality, but you got a bit tangled up in the sub-classing relationships. Have added some comments for now, so we can come back to it.

Definition: a complete Street that crosses multiple localities.

NOTE: In principle, a Street is composed of several StreetLocality members, however this relationship is not present in the GNAF Ontology. Furthermore, the GNAF product definition does not contain a class for Street, only for StreetLocality. The GNAF Ontology does not therefore correspond to the GNAF product in this area, and should be reviewed and potentially revised to capture the correct alignment. In particular, in the GNAF Ontology geometry is associated with gnaf:StreetLocality, but not with gnaf:Street which means that gnaf:Street as a sub-class of geo:Feature is not Loc-I conformant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants