Skip to content

Commit 32a1c61

Browse files
committed
tweaks to README from PR conversation
1 parent b1611b7 commit 32a1c61

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

README.md

+5-10
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ For local development, you can install Redis by following [these instructions](h
8686

8787
### Pyserver setup
8888

89-
- Go to `/pyserver` and run: `python<version> -m venv venv`
89+
- Go to `/pyserver` and run: `python -m venv venv`
9090
- Run `source ./.venv/bin/activate` to run the virtual environment
9191
- Install the project requirements by running `pip install -r requirements.txt`
9292
- You can test to see if it worked by running `fastapi dev main.py` and see if the server spins up.
@@ -109,7 +109,7 @@ export FIREBASE_DATABASE_URL= found in your firebase project
109109
export REDIS_HOST= for dev: localhost
110110
export REDIS_PORT= for dev: 6379
111111
export GOOGLE_APPLICATION_CREDENTIALS= path to your credentials. Suggest using ./credentials
112-
export NODE_ENV=
112+
export NODE_ENV= dev | prod
113113
```
114114

115115
#### next-client/.env
@@ -136,11 +136,6 @@ Note: Before doing anything, there is a bug that prevents `/common` from being b
136136

137137
To launch a local instance:
138138

139-
1. Open up your terminal and navigate to the repo folder (e.g. `/Desktop/tttc-light-js`)
140-
2. If this is your first time, build the repo: `cd commmon && npm run build`.
141-
3. Run `npm run dev` to start the dev server. This will run three servers in new terminal windows: the `next-client` frontend on `localhost:3000`, the `express-server` backend on `localhost:8080`, and the `pyserver` Python FastAPI server for the LLM calls on `localhost:8000`. A fourth terminal window will show a listener for `/common` that rebuilds the JS files when changes are made.
142-
4. This build will be optimized for production.
143-
===== << Merge conflict, let's discuss
144139
- Make sure you have completed the setup steps
145140
- At `/`, run `npm run dev`.
146141
- This will run three servers: the `next-client` frontend on localhost:3000, the `express-server` backend on localhost:8080, and the `pyserver` Python FastAPI server for the LLM calls on localhost:8000. Additionally, a watcher will spawn that rebuilds common when changes are made to it.
@@ -219,9 +214,9 @@ export type Options = {
219214
data: ['csv', {
220215
comment: string,
221216
id: string,
222-
interview: string,
223-
video: string,
224-
timestamp: string,
217+
interview: string | undefined,
218+
video: string | undefined,
219+
timestamp: string | undefined,
225220
}[]] | ['googlesheet', {
226221
url: string,
227222
pieChartColumns: string[],

0 commit comments

Comments
 (0)