Upgrade to .NET 8 #94
Conversation
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netstandard2.0</TargetFramework> | |||
There was a problem hiding this comment.
This needs to stay as standard 2.0 (can probably be bumped to 2.1 tho) because windows launcher is framework and thus relies on it.
It's the reason why CI fails.
There was a problem hiding this comment.
Reverted back to netstandard2.1.
There was a problem hiding this comment.
this needs to be standard 2.0
2.1 strips framework support :(
| @@ -16,13 +16,13 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-latest, macos-13, windows-latest] | |||
| os: [ubuntu-latest, macos-latest, windows-latest] | |||
There was a problem hiding this comment.
For background, the reason why i pinned it to -13 at one point was because eto/dotnet was behaving really strangely with back then it being latest. Not sure if it's fixed now.
There was a problem hiding this comment.
macos still fails, but I don't consider it blocking.
LLINK : warning MM0079: The recommended Xcode version for Microsoft.macOS 15.0.8319 is Xcode 16.0 or later. The current Xcode version (found in /Applications/Xcode_15.4.app/Contents/Developer) is 15.4. [/Users/runner/work/AM2RLauncher/AM2RLauncher/AM2RLauncher/AM2RLauncher.Mac/AM2RLauncher.Mac.csproj]
ILLink : unknown error IL7000: An error occurred while executing the custom linker steps. Please review the build log for more information. [/Users/runner/work/AM2RLauncher/AM2RLauncher/AM2RLauncher/AM2RLauncher.Mac/AM2RLauncher.Mac.csproj]
There was a problem hiding this comment.
@peeley you wanna try changing ~line 44 for this or keep it as is?
There was a problem hiding this comment.
Oh man, I didn't even notice that line. I was wondering why the Xcode version was behaving weirdly. I'm gonna just try and delete that, since the same command works locally on MacOS (and I don't see why that specific version of XCode is needed, instead of the latest version).
There was a problem hiding this comment.
macos-latest doesnt have the latest xcode enabled by default for whatever reason.
At least last that was the case when I added it. Deleting it doesnt actually do anyting because it currently doesnt already get triggered on your branch because its wrapped in an if macos-13, while we're on macos-latest
The switch there needs to be changed to 16.0 or 16.1
See here: https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md#xcode
There was a problem hiding this comment.
Turns out I was misunderstanding what macos-latest points to - I thought it was macos-15, but it points to macos-14 (src). macos-15 has the correct XCode version, so I think I need to point to macos-15 explicitly.
There was a problem hiding this comment.
macos-15 is still in beta (your source) so I'd like to not point to it explicitly.
I'd just point to macos-latest and have the xcode switch removed - by the time someone makes another pull request macos15 is hopefully Generally Available and then those tests.
|
nixos is able to point to a commit in the main development branch, right? Also im surprised the application works on arm64 macos |
We're able to import PR as patches that we apply on the latest stable release. If that doesn't work out of the box I can fiddle around with the patch a little more until it works. The reason I didn't upstream these changes is because they're really a hack meant to make it build with the .NET 8.0 SDK but there are quite a few other things that also need to be checked when upgrading such as breaking changes, older package versions that are still net6.0 and so on, so I opted to leave this kind of work to upstream as I never used this tool before and am just helping with the effort of removing all usages of .NET 6.0 in nix. |
peeley
force-pushed
the
upgrade-dotnet-8
branch
from
ec0ed2a to
489cd33
Compare
Yeah, we can just point to an arbitrary commit to update the package. There's no need for a full semver release. |
peeley
force-pushed
the
upgrade-dotnet-8
branch
from
489cd33 to
5d80417
Compare
.github/workflows/build.yml
Outdated
| @@ -16,13 +16,13 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-latest, macos-13, windows-latest] | |||
| os: [ubuntu-latest, macos-latest, windows-latest] | |||
| configuration: [Release] | |||
| include: | |||
| - os: ubuntu-latest | |||
| COMMAND: AM2RLauncher.Gtk -p:PublishSingleFile=true -p:DebugType=embedded -r ubuntu.18.04-x64 --no-self-contained | |||
There was a problem hiding this comment.
linux fails here:
The specified RuntimeIdentifier 'ubuntu.18.04-x64' is not recognized.
There was a problem hiding this comment.
Looks like the existing runtime is not one of the listed runtime identifiers - I'll add a commit to fix it.
There was a problem hiding this comment.
oh wow, i didnt notice that they cut off like half their RIDs
peeley
force-pushed
the
upgrade-dotnet-8
branch
from
455cf1b to
4e0a82d
Compare
peeley
force-pushed
the
upgrade-dotnet-8
branch
from
d0aa611 to
a9d1b7c
Compare
Fixes #93.
This PR upstreams the downstream changes from this patch (credit to @GGG-KILLER). I tested the upgrade on both x86 Linux and ARM64 MacOS, and (miraculously) it seems as though the application still works as expected without any other changes required. Unfortunately, I don't have a Windows PC to test these changes on; testing from other contributors would be greatly appreciated.
I also threw in a commit to try and fix the CI pipeline. It looks like the issue is with the version of MacOS that the GitHub workflow uses, hopefully updating to
macos-latestfixes it.