Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback Eto to 2.7.5 to fix crash, update Linux build instructions #97

Merged
merged 3 commits into from
Feb 2, 2025
Merged

Rollback Eto to 2.7.5 to fix crash, update Linux build instructions #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c58304
Downgrade Eto to 2.7.5 to prevent crash on launch
peeley Jan 29, 2025
e753cb1
Update Linux build instructions in README
peeley Jan 29, 2025
cd26a1a
Update Linux runtime identifier in buildAll.bat
peeley Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
include:
- os: ubuntu-latest
COMMAND: AM2RLauncher.Gtk -p:PublishSingleFile=true -p:DebugType=embedded -r linux-x64 --no-self-contained
ARTIFACT: AM2RLauncher/AM2RLauncher.Gtk/bin/Release/net8.0/ubuntu.18.04-x64/publish/
ARTIFACT: AM2RLauncher/AM2RLauncher.Gtk/bin/Release/net8.0/linux-x64/publish/
- os: macos-latest
COMMAND: AM2RLauncher.Mac -o builds/macOS-latest
ARTIFACT: AM2RLauncher/builds/macOS-latest
Expand Down
4 changes: 2 additions & 2 deletions AM2RLauncher/AM2RLauncher.Gtk/AM2RLauncher.Gtk.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Eto.Platform.Gtk" Version="2.8.0" />
<PackageReference Include="Eto.Platform.Gtk" Version="2.7.5" />
</ItemGroup>

<ItemGroup>
Expand All @@ -37,4 +37,4 @@
</EmbeddedResource>
</ItemGroup>

</Project>
</Project>
2 changes: 1 addition & 1 deletion AM2RLauncher/AM2RLauncher.Mac/AM2RLauncher.Mac.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Eto.Platform.macOS" Version="2.8.0" />
<PackageReference Include="Eto.Platform.macOS" Version="2.7.5" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion AM2RLauncher/AM2RLauncher.Wpf/AM2RLauncher.Wpf.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Eto.Platform.Windows" Version="2.8.0" />
<PackageReference Include="Eto.Platform.Windows" Version="2.7.5" />
</ItemGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion AM2RLauncher/AM2RLauncher/AM2RLauncher.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Eto.Forms" Version="2.8.0" />
<PackageReference Include="Eto.Forms" Version="2.7.5" />
<PackageReference Include="LibGit2Sharp" Version="0.31.0" />
<PackageReference Include="log4net" Version="2.0.15" />
<PackageReference Include="Microsoft.Win32.Registry" Version="5.0.0" />
Expand Down
5 changes: 2 additions & 3 deletions AM2RLauncher/buildAll.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@ dotnet publish AM2RLauncher.Wpf -c release -r win-x86 -o "builds\win86"
ROBOCOPY "builds\win86" "builds\win86\lib\ " /XF *.exe *.config *.manifest /XD lib logs data /E /IS /MOVE
move .\builds\win86\AM2RLauncher.Wpf.exe .\builds\win86\AM2RLauncher.exe
move .\builds\win86\AM2RLauncher.Wpf.exe.config .\builds\win86\AM2RLauncher.exe.config
dotnet publish AM2RLauncher.Gtk -p:PublishSingleFile=true -p:DebugType=embedded -c release -r ubuntu.18.04-x64 --no-self-contained -o "builds\linux64"
dotnet publish AM2RLauncher.Gtk -p:PublishSingleFile=true -p:DebugType=embedded -c release -r ubuntu.18.04-x64 --self-contained -o "builds\linux64-selfContained"

dotnet publish AM2RLauncher.Gtk -p:PublishSingleFile=true -p:DebugType=embedded -c release -r linux-x64 --no-self-contained -o "builds\linux64"
dotnet publish AM2RLauncher.Gtk -p:PublishSingleFile=true -p:DebugType=embedded -c release -r linux-x64 --self-contained -o "builds\linux64-selfContained"
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ Open the solution with Visual Studio 2019.
Alternatively, build via `dotnet build` / the `buildAll` batch file.

## Linux Instructions
In order to build for linux, use `dotnet publish AM2RLauncher.Gtk -p:PublishSingleFile=true -p:DebugType=embedded -c release -r ubuntu.18.04-x64 --no-self-contained`, MonoDevelop sadly doesn't work.
You *have* to specify it to build for Ubuntu, even on non-Ubuntu distros, because one of our Dependencies, libgit2sharp fails on the `linux-x64` RID.
In order to build for linux, use `dotnet publish AM2RLauncher.Gtk -p:PublishSingleFile=true -p:DebugType=embedded -c release -r linux-x64 --no-self-contained`, MonoDevelop sadly doesn't work.

### Arch Linux
An `am2rlauncher-git` [AUR Package](https://aur.archlinux.org/packages/am2rlauncher-git/) also exists.
Expand Down
Loading