Skip to content

Commit 513385b

Browse files
authored
Merge pull request #117 from ax3l/fix-ci-hiprand
CI: Fix HIP Builds
2 parents 74a44d8 + 8418fac commit 513385b

File tree

5 files changed

+11
-10
lines changed

5 files changed

+11
-10
lines changed

.github/workflows/dependencies/dependencies_hip.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ sudo apt-get update
3131
sudo apt-get install -y --no-install-recommends \
3232
build-essential \
3333
gfortran \
34+
hiprand-dev \
3435
libnuma-dev \
3536
libopenmpi-dev \
3637
openmpi-bin \

.github/workflows/linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ jobs:
246246
# ^
247247
# /opt/rocm-4.1.1/hip/include/hip/hcc_detail/hip_runtime.h:176:9: note: macro 'select_impl_' defined here
248248
# #define select_impl_(_1, _2, impl_, ...) impl_
249-
env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wno-deprecated-declarations -Wno-gnu-zero-variadic-macro-arguments -Wno-pass-failed"}
249+
env: {CXXFLAGS: "-Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wno-deprecated-declarations -Wno-gnu-zero-variadic-macro-arguments -Wno-pass-failed"}
250250
steps:
251251
- uses: actions/checkout@v3
252252
- name: Dependencies

ExampleCodes/Particles/ElectromagneticPIC/Exec/CUDA/Evolve.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ using namespace amrex;
99
Real compute_dt(const Geometry& geom, const amrex::Real& cfl)
1010
{
1111
const Real* dx = geom.CellSize();
12-
const Real dt = cfl * 1./( std::sqrt(D_TERM( 1./(dx[0]*dx[0]),
13-
+ 1./(dx[1]*dx[1]),
14-
+ 1./(dx[2]*dx[2]))) * PhysConst::c );
12+
const Real dt = cfl * 1./( std::sqrt(AMREX_D_TERM( 1./(dx[0]*dx[0]),
13+
+ 1./(dx[1]*dx[1]),
14+
+ 1./(dx[2]*dx[2]))) * PhysConst::c );
1515
return dt;
1616
}
1717

ExampleCodes/Particles/ElectromagneticPIC/Exec/OpenACC/Evolve.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ using namespace amrex;
88
Real compute_dt(const Geometry& geom, const amrex::Real& cfl)
99
{
1010
const Real* dx = geom.CellSize();
11-
const Real dt = cfl * 1./( std::sqrt(D_TERM( 1./(dx[0]*dx[0]),
12-
+ 1./(dx[1]*dx[1]),
13-
+ 1./(dx[2]*dx[2]))) * PhysConst::c );
11+
const Real dt = cfl * 1./( std::sqrt(AMREX_D_TERM( 1./(dx[0]*dx[0]),
12+
+ 1./(dx[1]*dx[1]),
13+
+ 1./(dx[2]*dx[2]))) * PhysConst::c );
1414
return dt;
1515
}
1616

ExampleCodes/Particles/ElectromagneticPIC/Exec/OpenMP/Evolve.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ using namespace amrex;
88
Real compute_dt(const Geometry& geom, const amrex::Real& cfl)
99
{
1010
const Real* dx = geom.CellSize();
11-
const Real dt = cfl * 1./( std::sqrt(D_TERM( 1./(dx[0]*dx[0]),
12-
+ 1./(dx[1]*dx[1]),
13-
+ 1./(dx[2]*dx[2]))) * PhysConst::c );
11+
const Real dt = cfl * 1./( std::sqrt(AMREX_D_TERM( 1./(dx[0]*dx[0]),
12+
+ 1./(dx[1]*dx[1]),
13+
+ 1./(dx[2]*dx[2]))) * PhysConst::c );
1414
return dt;
1515
}
1616

0 commit comments

Comments
 (0)