Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define BoxArray from list of Boxes #396

Closed
matilde-t opened this issue Dec 10, 2024 · 2 comments · Fixed by #406
Closed

Define BoxArray from list of Boxes #396

matilde-t opened this issue Dec 10, 2024 · 2 comments · Fixed by #406
Assignees
@ax3l
Labels
enhancement New feature or request

Comments

@matilde-t
Copy link

Hi,
I am trying to define a BoxArray from a list of Boxes that I create manually, which looks feasible in the C++ code, but I cannot find a way to do so in python. The constructors for BoxArray are only for a single Box and I don't know what the second one (with an int) does.

image
@ax3l ax3l self-assigned this Jan 22, 2025
@ax3l ax3l added the enhancement New feature or request label Jan 22, 2025
@ax3l
Copy link
Member

ax3l commented Jan 22, 2025

Hi @matilde-t , thanks for the report! This should be easy to add. Will submit a PR for 25.02

@ax3l ax3l mentioned this issue Jan 22, 2025
Merged
@ax3l
Copy link
Member

ax3l commented Jan 22, 2025

PR #406 adds the support and a test/demo.

ax3l added a commit that referenced this issue Jan 23, 2025
@ax3l
BoxArray: From List of Boxes (#406)
f115b24 
Add a contructor to create a `BoxArray` from a list of `Box`es.

Close #396
@ax3l ax3l closed this as completed in #406 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ax3l ax3l

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BoxArray: From List of Boxes ax3l/pyamrex
2 participants
@ax3l @matilde-t