Fix potential issues with scripts

akubera · akubera · commit df8b168be01b · 2023-09-28T23:08:00.000-04:00
diff --git a/scripts/benchmark-bigdecimal b/scripts/benchmark-bigdecimal
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 #
 # Run Criterion Benchmarks
 #
@@ -14,7 +14,7 @@ mv Cargo.toml.bak Cargo.toml
 
 
 # store extra things for the benchmarking report
-if [ ! -z "$BENCHMARK_EXTRAS" ]; then
+if [ -n "$BENCHMARK_EXTRAS" ]; then
 cat <<EOF > index.html
 <!doctype html>
 <head>
@@ -36,12 +36,12 @@ EOF
 # Add svg plots to index html
 find target/criterion -name 'pdf.svg' -type f -print0 |
 sort -z |
-while read -d $'\0' svg_file
+while read -r -d $'\0' svg_file
 do
-  name=$(echo $svg_file | cut -d '/' -f 3)
+  name=$(echo "$svg_file" | cut -d '/' -f 3)
 
   sample_datafile=target/criterion/$name/new/sample.json
-  if [ -f $sample_datafile ]; then
+  if [ -f "$sample_datafile" ]; then
     echo "<p><a href='${sample_datafile}' class='sample-json'>$name</a>" >> index.html
   else
     echo "<p>$name</p>" >> index.html
diff --git a/scripts/bigdecimal-property-tests b/scripts/bigdecimal-property-tests
@@ -35,7 +35,7 @@ case "${CMD}" in
 
   test)
     enable_property_tests
-    cargo test $@
+    cargo test "$@"
     restore_disabled_property_tests
     ;;
 
diff --git a/scripts/fetch-benchmark-data.sh b/scripts/fetch-benchmark-data.sh
@@ -16,16 +16,16 @@ function fetch_benchmark_bigdecimal_file() {
 	local FILENAME="random-bigdecimals-$1.txt"
 	local FILEPATH=$TEST_DATA_DIR/$FILENAME
 
-	if [ -e $FILEPATH ]; then
+	if [ -e "$FILEPATH" ]; then
 		echo "exists: $FILEPATH"
 	else
 		local URL=${GITLAB_URL_PATTERN//<FILENAME>/$FILENAME}
 		echo "fetching: $FILEPATH from $URL"
 
-		if [ $CURL ]; then
-			$CURL -s --fail -L $URL -o "$FILEPATH"
-		elif [ $WGET ]; then
-			$WGET --quiet $URL -O "$FILEPATH"
+		if [ "$CURL" ]; then
+			$CURL -s --fail -L "$URL" -o "$FILEPATH"
+		elif [ "$WGET" ]; then
+			"$WGET" --quiet "$URL" -O "$FILEPATH"
 		else
 			echo "No supported fetching program"
 		fi
