How to call spi_free()

[janjongboom]

I need to call spi_free() because my SPI flash chip does not like to be init'ed from both bootloader and app.

But it's not available in the C++ API... Any idea how to do it?

[JojoS62]

I doubt that it will help because I've seen only empty implementations. And the comment in hal/spi_api.h says:

/** Release a SPI object
 *
 * TODO: spi_free is currently unimplemented
 * This will require reference counting at the C++ level to be safe
 *
 * Return the pins owned by the SPI object to their reset state
 * Disable the SPI peripheral
 * Disable the SPI clock
 * @param[in] obj The SPI object to deinitialize
 */
void spi_free(spi_t *obj);

[0xc0170]

This will require further work, as noted above, in the documentation, needs specification and implementation for targets.

[janjongboom]

@0xc0170 I'd suggest adding a free() function to SPI object. Perhaps we'd mark it in the docs with an indication that you probably never want to call it.

[ciarmcom]

ARM Internal Ref: MBOTRIAGE-188

[janjongboom]

Just in case someone else runs into this problem, I made a DestructableSPI class which can free the interface: https://github.com/janjongboom/at45-blockdevice/blob/44766342130b373f59ac372add62e73f55469f9b/DestructableSPI.h

[ithinuel]

This is also addressed in the [WIP] SPI hal update.

[deepikabhavnani]

Issue is addressed in SPI hal, can this be closed now?

[janjongboom]

@deepikabhavnani Where was the SPI Hal work landed?

[deepikabhavnani]

Ready to merge #7671 - Feature branch feature-hal-spec-spi.

[janjongboom]

@deepikabhavnani That's just design documents, where is the actual work? Unless there's some actual work being done we cannot close this.

[ithinuel]

There are work on reference implementations for some ST's and Freescale's targets.
They'll be part of an upcomig PR to the same feature branch.

[deepikabhavnani]

Duplicate of #3106.
Please use the Issue: 3106 to track anything related to destructor, free pins, disable module / driver.. etc