Skip to content
This repository was archived by the owner on Jul 7, 2025. It is now read-only.

Commit 2d2ccbe

Browse files
authored
Merge pull request #137 from ASAP-Lettering/ASAP-461
ASAP-461 익명 및 회원 편지 발신자 조회 로직 수정
2 parents 34cdd81 + 22cb0e3 commit 2d2ccbe

File tree

6 files changed

+241
-108
lines changed

6 files changed

+241
-108
lines changed

Application-Module/src/main/kotlin/com/asap/application/letter/service/LetterCommandService.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,16 +106,13 @@ class LetterCommandService(
106106
receiverId = DomainId(command.userId),
107107
letterId = DomainId(command.letterId),
108108
)
109+
109110
val independentLetter =
110111
IndependentLetter.create(
111112
sender =
112113
SenderInfo(
113114
senderId = sendLetter.senderId,
114-
senderName =
115-
sendLetter.senderName
116-
?: sendLetter.senderId
117-
?.let { userManagementPort.getUserNotNull(it).username }
118-
.orEmpty(),
115+
senderName = sendLetter.senderName ?: ANONYMOUS_SENDER_NAME,
119116
),
120117
receiver =
121118
ReceiverInfo(

Application-Module/src/main/kotlin/com/asap/application/letter/service/LetterQueryService.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import com.asap.application.letter.port.out.IndependentLetterManagementPort
55
import com.asap.application.letter.port.out.SendLetterManagementPort
66
import com.asap.application.letter.port.out.SpaceLetterManagementPort
77
import com.asap.application.space.port.out.SpaceManagementPort
8-
import com.asap.application.user.port.out.UserManagementPort
98
import com.asap.common.page.PageRequest
109
import com.asap.common.page.Sort
1110
import com.asap.domain.common.DomainId
@@ -16,7 +15,6 @@ import org.springframework.transaction.annotation.Transactional
1615
@Transactional(readOnly = true)
1716
class LetterQueryService(
1817
private val sendLetterManagementPort: SendLetterManagementPort,
19-
private val userManagementPort: UserManagementPort,
2018
private val independentLetterManagementPort: IndependentLetterManagementPort,
2119
private val spaceLetterManagementPort: SpaceLetterManagementPort,
2220
private val spaceManagementPort: SpaceManagementPort,
@@ -32,9 +30,8 @@ class LetterQueryService(
3230
receiverId = DomainId(query.userId),
3331
letterId = DomainId(query.letterId),
3432
).also {
35-
val sender = it.senderId?.let { userManagementPort.getUserNotNull(it) }
3633
return GetVerifiedLetterUsecase.Response(
37-
senderName = sender?.username,
34+
senderName = it.senderName,
3835
content = it.content.content,
3936
sendDate = it.createdDate,
4037
templateType = it.content.templateType,
@@ -76,7 +73,7 @@ class LetterQueryService(
7673
independentLetterManagementPort.getNearbyLetter(DomainId(query.userId), DomainId(query.letterId))
7774
return GetIndependentLettersUsecase.Response.One(
7875
senderName = letter.sender.senderName,
79-
letterCount = letterCount.toLong(),
76+
letterCount = letterCount,
8077
content = letter.content.content,
8178
sendDate = letter.receiveDate,
8279
images = letter.content.images,

0 commit comments

Comments
 (0)