Skip to content

Commit 1f5c4ca

Browse files
committed
Fixed broken css after minification. Disable minification,
improve settings to support newer version of compressor. * askbot/deployment/templates/settings_py.jinja2, askbot/setup_templates/settings.py.jinja2, testproject/testproject/settings.py; - migrated from COMPRESS_JS_FILTERS to COMPRESS_FILTERS * askbot/jinja2/ask/index.html: - highlightSyntax -> highlightAll renamed at call sites * deleted askbot/media/css/prettify.css * deleted askbot/media/jslib/prettify.js b/askbot/media/jslib/prettify.js * askbot/startup_procedures.py: - error when COMPRESS_JS_FILTERS is used require to migrate to COMPRESS_FILTERS - if COMPRESS_FILTERS['js'] is not empty - error out - we do not support minification yet
1 parent e956b9a commit 1f5c4ca

File tree

7 files changed

+43
-87
lines changed

7 files changed

+43
-87
lines changed

askbot/deployment/templates/settings_py.jinja2

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,13 @@ if 'ASKBOT_CSS_DEVEL' in locals() and ASKBOT_CSS_DEVEL == True:
213213
('text/less', 'lessc {infile} {outfile}'),
214214
)
215215

216-
COMPRESS_JS_FILTERS = []
216+
COMPRESS_FILTERS = {
217+
'css': [
218+
'compressor.filters.css_default.CssAbsoluteFilter',
219+
'compressor.filters.cssmin.rCSSMinFilter',
220+
],
221+
'js': [],
222+
}
217223
COMPRESS_PARSER = 'compressor.parser.HtmlParser'
218224
JINJA2_EXTENSIONS = ('compressor.contrib.jinja2ext.CompressorExtension',)
219225
JINJA2_TEMPLATES = ('captcha',) # FIXME: unused but checked in startup_procedures

askbot/jinja2/ask/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@
8181
highlight: false,
8282
wait: 3000,
8383
captureLength: 5,
84-
callback: highlightSyntax
84+
callback: function() { hljs.highlightAll(); }
8585
});
86-
highlightSyntax();
86+
hljs.highlightAll();
8787

8888
if (askbot['data']['userIsAuthenticated']) {
8989
var draftHandler = new DraftQuestion();

askbot/media/css/prettify.css

Lines changed: 0 additions & 27 deletions
This file was deleted.

askbot/media/jslib/prettify.js

Lines changed: 0 additions & 52 deletions
This file was deleted.

askbot/setup_templates/settings.py.jinja2

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,13 @@ if 'ASKBOT_CSS_DEVEL' in locals() and ASKBOT_CSS_DEVEL == True:
342342
('text/less', 'lessc {infile} {outfile}'),
343343
)
344344

345-
COMPRESS_JS_FILTERS = []
345+
COMPRESS_FILTERS = {
346+
'css': [
347+
'compressor.filters.css_default.CssAbsoluteFilter',
348+
'compressor.filters.cssmin.rCSSMinFilter',
349+
],
350+
'js': [],
351+
}
346352
COMPRESS_PARSER = 'compressor.parser.HtmlParser'
347353
JINJA2_EXTENSIONS = ('compressor.contrib.jinja2ext.CompressorExtension',)
348354
JINJA2_TEMPLATES = ('captcha',) # FIXME: unused but checked in startup_procedures

askbot/startup_procedures.py

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -374,11 +374,28 @@ def test_compressor():
374374
"""test settings for django compressor"""
375375
errors = list()
376376

377-
js_filters = getattr(django_settings, 'COMPRESS_JS_FILTERS', [])
377+
new_filters_msg = (
378+
'Please replace COMPRESS_JS_FILTERS with COMPRESS_FILTERS in your settings.py:\n'
379+
"COMPRESS_FILTERS = {\n"
380+
" 'css': [\n"
381+
" 'compressor.filters.css_default.CssAbsoluteFilter',\n"
382+
" 'compressor.filters.cssmin.rCSSMinFilter',\n"
383+
" ],\n"
384+
" 'js': [],\n"
385+
"}"
386+
)
387+
388+
if hasattr(django_settings, 'COMPRESS_JS_FILTERS'):
389+
errors.append(
390+
'COMPRESS_JS_FILTERS is deprecated and ignored by django-compressor.\n'
391+
+ new_filters_msg
392+
)
393+
394+
compress_filters = getattr(django_settings, 'COMPRESS_FILTERS', {})
395+
js_filters = compress_filters.get('js', [])
378396
if js_filters:
379397
errors.append(
380-
'Askbot does not yet support js minification, please add to your settings.py:\n'
381-
'COMPRESS_JS_FILTERS = []'
398+
'Askbot does not yet support js minification.\n' + new_filters_msg
382399
)
383400

384401
if 'compressor' not in django_settings.INSTALLED_APPS:

testproject/testproject/settings.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,13 @@
320320
('text/less', 'lessc {infile} {outfile}'),
321321
)
322322

323-
COMPRESS_JS_FILTERS = []
323+
COMPRESS_FILTERS = {
324+
'css': [
325+
'compressor.filters.css_default.CssAbsoluteFilter',
326+
'compressor.filters.cssmin.rCSSMinFilter',
327+
],
328+
'js': [],
329+
}
324330
COMPRESS_PARSER = 'compressor.parser.HtmlParser'
325331
JINJA2_EXTENSIONS = ('compressor.contrib.jinja2ext.CompressorExtension',)
326332
JINJA2_TEMPLATES = ('captcha',)

0 commit comments

Comments
 (0)