Skip to content

Commit ec70cec

Browse files
committed
fixing low rank to return array{T,2}
1 parent d70dce9 commit ec70cec

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

src/sklearn.jl

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,6 @@ function generate_classification(; n_samples::Int = 100,
240240
return convert(features, labels)
241241
end
242242

243-
244243
"""
245244
function generate_low_rank_matrix(; n_samples::Int =100,
246245
n_features::Int =100,
@@ -267,8 +266,5 @@ function generate_low_rank_matrix(; n_samples::Int = 100,
267266
effective_rank = effective_rank,
268267
tail_strength = tail_strength,
269268
random_state = random_state)
270-
labels = zeros(size(features, 1))
271-
272-
return convert(features, labels)
273-
269+
return features
274270
end

test/runtests.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ using Test
4444
n_features = features,
4545
n_classes = 1)
4646

47-
4847
@test size(data)[1] == samples
4948
@test size(data)[2] == features + 1
5049

@@ -56,6 +55,5 @@ using Test
5655

5756

5857
@test size(data)[1] == samples
59-
@test size(data)[2] == features + 1
60-
58+
@test size(data)[2] == features
6159
end

0 commit comments

Comments
 (0)