Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D][Tester B] Unclear constraints for add feature in UG #75

Closed
nus-pe-script opened this issue Apr 5, 2024 · 2 comments · Fixed by #141
Closed

[PE-D][Tester B] Unclear constraints for add feature in UG #75

nus-pe-script opened this issue Apr 5, 2024 · 2 comments · Fixed by #141
Assignees
Labels
PE-D.Good Good bug report by PE-D tester priority.High Extra attention is needed severity.Medium Flaw that causes occasional inconvenience to some users type.DocumentationBug A flaw in the documentation e.g., a missing step, a wrong instruction, typos
Milestone

Comments

@nus-pe-script
Copy link

Constraint states that there should be no contacts with the same information.

image.png

However, "same information" in the context is not clear and seems to only be name constraints.

Steps taken:

  1. add n/John Doe e/[email protected] p/98765432 c/participant g/1

image.png

  1. Running the same command gives person already exists error (expected)

  2. Running with email change gives person already exists error (expected since still share same name and phone information)

image.png

  1. Running with parameters except different name allows adding of the person. (unexpected)

image.png

image.png


Labels: type.DocumentationBug severity.VeryLow
original: KohGuanZeh/ped#4

@bachletuankhai bachletuankhai self-assigned this Apr 6, 2024
@bachletuankhai bachletuankhai added this to the v1.4 milestone Apr 6, 2024
@bachletuankhai
Copy link

  • descriptive title: ✔️
  • enough details: ✔️
  • severity/type labels chosen are not too far off: ✔️
  • non-confrontational tone: ✔️
  • points out a potentially problematic behavior (or a good way to improve the product): ✔️

Good report

@bachletuankhai
Copy link

See #79. This is the document side of the same problem.

@bachletuankhai bachletuankhai added priority.High Extra attention is needed severity.Medium Flaw that causes occasional inconvenience to some users type.DocumentationBug A flaw in the documentation e.g., a missing step, a wrong instruction, typos PE-D.Good Good bug report by PE-D tester labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PE-D.Good Good bug report by PE-D tester priority.High Extra attention is needed severity.Medium Flaw that causes occasional inconvenience to some users type.DocumentationBug A flaw in the documentation e.g., a missing step, a wrong instruction, typos
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants