Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Circe as serde library for JSON in Agent, Server and Model modules #200

Closed
salamonpavel opened this issue May 24, 2024 · 2 comments · Fixed by #214
Closed

Use Circe as serde library for JSON in Agent, Server and Model modules #200

salamonpavel opened this issue May 24, 2024 · 2 comments · Fixed by #214
Assignees
@TebaleloS
Labels
enhancement New feature or request

Comments

@salamonpavel
Copy link
Collaborator

salamonpavel commented May 24, 2024 •
edited
Loading

We have decided to use Circe in our projects (Atum, AUL). It's about time to replace the existing serialization with Circe based one.
@salamonpavel salamonpavel added the enhancement New feature or request label May 24, 2024
@salamonpavel salamonpavel mentioned this issue May 24, 2024
Merged
@lsulak
Copy link
Collaborator

lsulak commented May 31, 2024

Perhaps as part of this effort, it might make sense to:

  • adopt Atum Agent so that it's perfectly compatible with newly implemented envelopes in response envelope #199 in all the versions
  • perhaps move the envelope related code to model/ ❓ just a suggestion

@zakera786 zakera786 moved this from 🆕 To groom to 🔖 Sprint in CPS small repos project Jun 7, 2024
@TebaleloS TebaleloS self-assigned this Jun 7, 2024
This was referenced Jun 12, 2024
Merged
Open
@lsulak
Copy link
Collaborator

lsulak commented Jun 14, 2024

also please test / check if this is still a bug once you have your solution there: #133

@TebaleloS TebaleloS mentioned this issue Jun 25, 2024
Merged
TebaleloS added a commit that referenced this issue Jul 1, 2024
@TebaleloS
Merge branch 'master' into feature/#200-Use-circe-as-serde-lib-forjson
66bbbc9
TebaleloS added a commit that referenced this issue Jul 2, 2024
@TebaleloS
Merge branch 'feature/#200-Use-circe-as-serde-lib-forjson' of https:/…
a3d2b20 
…/github.com/AbsaOSS/atum-service into feature/#200-Use-circe-as-serde-lib-forjson
benedeki added a commit that referenced this issue Jul 11, 2024
@TebaleloS @salamonpavel @benedeki
#200: Use Circe as serde library for JSON in Agent, Server and Model …
663e2a3 
…modules

* addid circe dependency and using it
* using circe syntax in flow classes
* removing play Json dependencies, and PlayJsonImplicits class
* revised arrayPutUsing string implicit conversion
* removed json4s and replaced its usage
* defining implicits in the companion objects of the given DTOs
* removing jacksonModuleScala
* Redefining ResultValueType custom types

---------

Co-authored-by: Pavel Salamon <[email protected]>
Co-authored-by: David Benedeki <[email protected]>
@github-project-automation github-project-automation bot moved this from 🔖 Sprint to ✅ Done in CPS small repos project Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TebaleloS TebaleloS

Labels
enhancement New feature or request
Projects
CPS small repos project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use circe as serde lib for json: 200 AbsaOSS/atum-service
3 participants
@lsulak @salamonpavel @TebaleloS