Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change checkpoint's table DDL, set column measured_by_atum_agent to have NOT NULL constraint with DEFAULT FALSE #242

Open
salamonpavel opened this issue Aug 9, 2024 · 2 comments · May be fixed by #319
Open

Change checkpoint's table DDL, set column measured_by_atum_agent to have NOT NULL constraint with DEFAULT FALSE #242

salamonpavel opened this issue Aug 9, 2024 · 2 comments · May be fixed by #319
Assignees
@ABLL526
Labels
enhancement New feature or request

Comments

@salamonpavel
Copy link
Collaborator

salamonpavel commented Aug 9, 2024 •
edited by benedeki
Loading

Change checkpoint's table DDL, set column measured_by_atum_agent to have NOT NULL constraint with DEFAULT FALSE
@salamonpavel salamonpavel added the enhancement New feature or request label Aug 9, 2024
@benedeki
Copy link
Contributor

benedeki commented Dec 4, 2024

Why is the default false and not true?

ABLL526 added a commit that referenced this issue Feb 21, 2025
@ABLL526
Change checkpoint's table DDL, set column measured_by_atum_agent to h…
9b43abc 
…ave NOT NULL constraint with DEFAULT FALSE #242

Made changes:
1. Changed the value of measured_by_atum_agent in Checkpoints DDL to NOT NULL.
2. Changed the value of measured_by_atum_agent in Checkpoints DDL to DEFAULT FALSE.
3. Changed the value of measured_by_atum_agent in Write Checkpoints to DEFAULT FALSE.
4. Changed the tests to accommodate this change, it has been tested successfully.
@ABLL526 ABLL526 self-assigned this Feb 21, 2025
@ABLL526 ABLL526 linked a pull request Feb 21, 2025 that will close this issue
Open
@ABLL526 ABLL526 linked a pull request Feb 21, 2025 that will close this issue
Change checkpoint's table DDL, set column measured_by_atum_agent to h… #319
Open
@ABLL526 ABLL526 removed a link to a pull request Feb 21, 2025
Change checkpoint's table DDL, set column measured_by_atum_agent to h… #319
Open
@ABLL526 ABLL526 linked a pull request Feb 21, 2025 that will close this issue
Change checkpoint's table DDL, set column measured_by_atum_agent to h… #319
Open
@ABLL526
Copy link

ABLL526 commented Feb 21, 2025

I have made the changes but I made the default FALSE. I can always change it to true,

ABLL526 added a commit that referenced this issue Feb 21, 2025
@ABLL526
Change checkpoint's table DDL, set column measured_by_atum_agent to h…
b02fdc0 
…ave NOT NULL constraint with DEFAULT FALSE #242

Made changes:
1. Changed the value of measured_by_atum_agent in Checkpoints DDL to NOT NULL.
2. Changed the value of measured_by_atum_agent in Checkpoints DDL to DEFAULT FALSE.
3. Changed the value of measured_by_atum_agent in Write Checkpoints to DEFAULT FALSE.
4. Changed the tests to accommodate this change, it has been tested successfully.
5. Made changes to the WriteCheckpoint.scala files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ABLL526 ABLL526

Labels
enhancement New feature or request
Projects
CPS small repos project
Status: 🆕 To groom
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change checkpoint's table DDL, set column measured_by_atum_agent to h… AbsaOSS/atum-service
3 participants
@benedeki @salamonpavel @ABLL526