U308-038 Replace BinTray with AWS S3

Author: reznikmm

.github/workflows/build-binaries.sh

@@ -30,9 +30,12 @@ if [[ ${GITHUB_REF##*/} != 2*.[0-9]*.[0-9]* ]]; then
     git rebase --verbose origin/edge
 fi
 
+# Get libadalang binaries
 mkdir -p $prefix
-URL=https://bintray.com/reznikmm/libadalang/download_file\?file_path=libadalang-$RUNNER_OS-$BRANCH${DEBUG:+-dbg}-static.tar.gz
-curl -L $URL | tar xzf - -C $prefix
+FILE=libadalang-$RUNNER_OS-$BRANCH${DEBUG:+-dbg}-static.tar.gz
+aws s3 cp s3://adacore-gha-tray-eu-west-1/libadalang/$FILE . --sse=AES256
+tar xzf $FILE -C $prefix
+rm -f -v $FILE
 gprinstall --uninstall gnatcoll || true
 gprinstall --uninstall gpr || true
 rm -f -v gnat/spawn*.gpr
@@ -58,14 +61,9 @@ function fix_rpath ()
     install_name_tool -add_rpath @executable_path $1
 }
 
-if [ $RUNNER_OS = Windows ]; then
-    tar czvf $RUNNER_OS${DEBUG:+-dbg}-$TAG.tar.gz -C integration/vscode/ada/ win32
-elif [ $RUNNER_OS = macOS ]; then
+if [ $RUNNER_OS = macOS ]; then
     cp -v /usr/local/opt/gmp/lib/libgmp.10.dylib integration/vscode/ada/darwin/
     fix_rpath integration/vscode/ada/darwin/ada_language_server
-    tar czvf $RUNNER_OS${DEBUG:+-dbg}-$TAG.tar.gz -C integration/vscode/ada/ darwin
-else
-    tar czvf $RUNNER_OS${DEBUG:+-dbg}-$TAG.tar.gz -C integration/vscode/ada/ linux
 fi
 
 if [ "$DEBUG" != "debug" ]; then

.github/workflows/build-binaries.yml

@@ -8,6 +8,7 @@ on:
 name: Build binaries
 env:
   DEFAULT_TAG: 22.0.999
+  AWS_DEFAULT_REGION: eu-west-1
 jobs:
   build:
     name: Build and deploy
@@ -72,13 +73,19 @@ jobs:
       - name: Build (Windows)
         if: ${{ runner.os == 'Windows' }}
         shell: msys2 {0}
+        env:
+          AWS_ACCESS_KEY_ID: ${{secrets.GHA_CACHE_ACCESS_KEY_ID}}
+          AWS_SECRET_ACCESS_KEY: ${{secrets.GHA_CACHE_SECRET}}
         run: |
           # drop python if any
           rm -rf -v ./cached_gnat/gnat*/bin/python*
           # This is to avoid locking .sh on win that prevents its updating
           cp .github/workflows/build-binaries.sh .github/workflows/build-binaries.sh_
           .github/workflows/build-binaries.sh_ "${{ matrix.debug }}" ${{ runner.os }} ${{ env.TAG }}
       - name: Build (non-Windows)
+        env:
+          AWS_ACCESS_KEY_ID: ${{secrets.GHA_CACHE_ACCESS_KEY_ID}}
+          AWS_SECRET_ACCESS_KEY: ${{secrets.GHA_CACHE_SECRET}}
         if: ${{ runner.os != 'Windows' }}
         run: .github/workflows/build-binaries.sh "${{ matrix.debug }}" ${{ runner.os }} ${{ env.TAG }}
       - name: Archive ALS binary
@@ -87,18 +94,6 @@ jobs:
         with:
           name: als-${{ runner.os }}-${{ matrix.debug }}
           path: integration/vscode/ada/[ldw]*/*
-      - name: Upload tar-ball to Bintray
-        if: ${{ github.event_name == 'push' }}
-        uses: reznikmm/upload-bintray-action@v4
-        with:
-          subject: reznikmm
-          username: reznikmm
-          repository: ada-language-server
-          package: ada-language-server
-          version: ${{ env.TAG }}
-          sourcePath: '*.tar.gz'
-          override: 1
-          apiKey: ${{secrets.BINTRAY_API_KEY}}
   package:
     if: ${{ github.event_name == 'push' }}
     needs: build
@@ -118,14 +113,8 @@ jobs:
           echo "TAG=$TAG" >> $GITHUB_ENV
           .github/workflows/pack-binaries.sh ""      "${{secrets.VSCE_TOKEN}}" "${{secrets.OPENVSX_TOKEN}}" $TAG
           .github/workflows/pack-binaries.sh "debug" "${{secrets.VSCE_TOKEN}}" "${{secrets.OPENVSX_TOKEN}}" $TAG
-      - name: Upload vsix to Bintray
-        uses: reznikmm/upload-bintray-action@v4
+      - name: Archive ALS vsix
+        uses: actions/upload-artifact@v2
         with:
-          subject: reznikmm
-          username: reznikmm
-          repository: ada-language-server
-          package: ada-language-server
-          version: ${{ env.TAG }}
-          sourcePath: '*.vsix'
-          override: 1
-          apiKey: ${{secrets.BINTRAY_API_KEY}}
+          name: als-vsix-${{ matrix.debug }}${{ env.TAG }}
+          path: '*.vsix'

README.md

@@ -2,7 +2,9 @@
 # Ada Language Server
 
 [![Build binaries](https://github.com/AdaCore/ada_language_server/workflows/Build%20binaries/badge.svg)](https://github.com/AdaCore/ada_language_server/actions)
-[![Download](https://api.bintray.com/packages/reznikmm/ada-language-server/ada-language-server/images/download.svg) ](https://bintray.com/reznikmm/ada-language-server/ada-language-server/_latestVersion)
+[![GitHub tag (latest by date)](https://img.shields.io/github/v/tag/AdaCore/ada_language_server)](https://github.com/AdaCore/ada_language_server/releases)
+[![VS Marketplace](https://img.shields.io/visual-studio-marketplace/v/adacore.ada?label=VS%20Marketplace)](https://marketplace.visualstudio.com/items?itemName=AdaCore.ada)
+[![Open VSX Registry](https://img.shields.io/open-vsx/v/AdaCore/ada?label=Open%20VSX)](https://open-vsx.org/extension/AdaCore/ada)
 [![Gitpod ready-to-code](https://img.shields.io/badge/Gitpod-ready--to--code-blue?logo=gitpod)](https://gitpod.io/#https://github.com/AdaCore/ada_language_server/tree/edge)
 
 This repository contains an implementation of the [Microsoft Language Server Protocol](https://microsoft.github.io/language-server-protocol/)
@@ -17,9 +19,9 @@ Current features:
  * Code folding and formatting.
 
 We also provide [Visual Studio Code](https://code.visualstudio.com/)
-extension
-[at the Marketplace](https://marketplace.visualstudio.com/items?itemName=AdaCore.ada) and
-[the latest build as .vsix file](https://dl.bintray.com/reznikmm/ada-language-server/ada-22.0.999.vsix).
+extension at
+[the VS Marketplace](https://marketplace.visualstudio.com/items?itemName=AdaCore.ada) and at
+[the Open VSX Registry](https://open-vsx.org/extension/AdaCore/ada).
 
 ## Table of Contents
  * [Install](#Install)
@@ -42,21 +44,8 @@ extension
 
 ## Install
 
-You can install
-[binary image](https://bintray.com/reznikmm/ada-language-server/ada-language-server#files)
-or build language server from sources.
-
-To install binary image download an archive corresponding to your OS and unpack it
-somewhere. You will find `ada_language_server` inside unpacked folder.
-We provide binaries for
- * Linux x86_64 - take
-[linux.tar.gz](https://dl.bintray.com/reznikmm/ada-language-server/linux-latest.tar.gz)
- * Window 64 bit - take
-[win32.zip](https://dl.bintray.com/reznikmm/ada-language-server/win32-latest.zip)
- * Mac OS X - take
-[darwin.tar.gz](https://dl.bintray.com/reznikmm/ada-language-server/darwin-latest.tar.gz)
-
-To build is from source install dependencies and run
+You can build language server from sources.
+To build is from sources install dependencies and run
 ```
 make
 ```
@@ -68,8 +57,9 @@ It will build `.obj/server/ada_language_server` file.
 To build the language server you need:
 
  * A GNAT compiler
- * [Libadalang](https://github.com/AdaCore/libadalang) library (it should be
+ * The [Libadalang](https://github.com/AdaCore/libadalang) library (it should be
    built)
+ * The [Libadalang-tools](https://github.com/AdaCore/libadalang-tools) library
  * The [VSS](https://github.com/AdaCore/VSS) library
  * The a process [spawn](https://github.com/AdaCore/spawn) library
 
@@ -136,7 +126,7 @@ client provides its-own way to set such settings.
 | `textDocument/completion`             | :white_check_mark: |
 | `completionItem/resolve`              |                    |
 | `textDocument/hover`                  | :white_check_mark: |
-| `textDocument/signatureHelp`          |                    |
+| `textDocument/signatureHelp`          | :white_check_mark: |
 | `textDocument/definition`             | :white_check_mark: |
 | `textDocument/declaration`            | :white_check_mark: |
 | `textDocument/typeDefinition`         | :white_check_mark: |
@@ -186,7 +176,7 @@ You can bind keyboard shortcuts to them by adding to the `keybindings.json` file
 }
 ```
 
-### Launch extension to debug it
+### Launch the extension to debug it
 For the moment, this repository includes a vscode extension that is used as the
 reference extension for this implementation.
 

integration/vscode/ada/README.md

@@ -1,9 +1,13 @@
 # Ada/SPARK for Visual Studio Code
 
-#### [Repository](https://github.com/AdaCore/ada_language_server)  |  [Issues](https://github.com/AdaCore/ada_language_server/issues)  |  [Documentation](https://github.com/AdaCore/ada_language_server/blob/master/integration/vscode/ada/README.md)  |  [Code Samples](https://github.com/AdaCore/ada_language_server/tree/master/integration/vscode/Code%20Samples)  |  [Offline Installers](https://bintray.com/reznikmm/ada-language-server/ada-language-server/_latestVersion)
+#### [Repository](https://github.com/AdaCore/ada_language_server)  |  [Issues](https://github.com/AdaCore/ada_language_server/issues)  |  [Documentation](https://github.com/AdaCore/ada_language_server/blob/master/integration/vscode/ada/README.md)  |  [Code Samples](https://github.com/AdaCore/ada_language_server/tree/master/integration/vscode/Code%20Samples)
 
 
-[![Build Status](https://travis-ci.org/AdaCore/ada_language_server.svg?branch=master)](https://travis-ci.org/AdaCore/ada_language_server)
+[![Build binaries](https://github.com/AdaCore/ada_language_server/workflows/Build%20binaries/badge.svg)](https://github.com/AdaCore/ada_language_server/actions)
+[![GitHub tag (latest by date)](https://img.shields.io/github/v/tag/AdaCore/ada_language_server)](https://github.com/AdaCore/ada_language_server/releases)
+[![VS Marketplace](https://img.shields.io/visual-studio-marketplace/v/adacore.ada?label=VS%20Marketplace)](https://marketplace.visualstudio.com/items?itemName=AdaCore.ada)
+[![Open VSX Registry](https://img.shields.io/open-vsx/v/AdaCore/ada?label=Open%20VSX)](https://open-vsx.org/extension/AdaCore/ada)
+[![Gitpod ready-to-code](https://img.shields.io/badge/Gitpod-ready--to--code-blue?logo=gitpod)](https://gitpod.io/#https://github.com/AdaCore/ada_language_server/tree/edge)
 
 This extension provides support for Ada/SPARK programing language via
 [Ada language server](https://github.com/AdaCore/ada_language_server)