U315-010 Use Python to make symbol link in the test.

Print stderr/stdout of launched command for debug purpose.
Add an Python example to the README.md

Author: reznikmm

Makefile

@@ -132,6 +132,7 @@ vscode-test:
 
 check: all
 	set -e; \
+        export PYTHON=$(PYTHON); \
         if [ `$(PYTHON) -c "import sys;print('e3' in sys.modules)"` = "True" ]; then\
            (cd testsuite ; sh run.sh ) ; \
         else \

source/tester/tester-tests.adb

@@ -17,13 +17,18 @@
 
 with Ada.Command_Line;
 with Ada.Directories;
+with Ada.Streams;
 with Ada.Text_IO;
 with Ada.Strings.Unbounded; use Ada.Strings.Unbounded;
 with GNAT.OS_Lib;           use GNAT.OS_Lib;
 
 with GNATCOLL.Utils; use GNATCOLL.Utils;
 with GNATCOLL.JSON;  use GNATCOLL.JSON;
 
+with VSS.Stream_Element_Vectors;
+with VSS.Strings.Conversions;
+with VSS.Strings.Converters.Decoders;
+
 with Spawn.Processes.Monitor_Loop;
 
 package body Tester.Tests is
@@ -168,6 +173,13 @@ package body Tester.Tests is
       function To_Program (Name : String) return String;
       --  Take base name of the command and find it on PATH
 
+      procedure Print (V : VSS.Stream_Element_Vectors.Stream_Element_Vector);
+      --  Print V as string.
+
+      ----------------
+      -- To_Program --
+      ----------------
+
       function To_Program (Name : String) return String is
          Found : GNAT.OS_Lib.String_Access :=
            GNAT.OS_Lib.Locate_Exec_On_Path (Name);
@@ -181,10 +193,20 @@ package body Tester.Tests is
       Cmd   : constant String := To_Program (GNATCOLL.JSON.Get (List, 1).Get);
       Args  : Spawn.String_Vectors.UTF_8_String_Vector;
 
-      type Shell_Listener is new Spawn.Processes.Process_Listener with record
-         Done : Boolean := False;
+      type Shell_Listener is limited new Spawn.Processes.Process_Listener with
+      record
+         Process : Spawn.Processes.Process;
+         Done    : Boolean := False;
+         Stdout  : VSS.Stream_Element_Vectors.Stream_Element_Vector;
+         Stderr  : VSS.Stream_Element_Vectors.Stream_Element_Vector;
       end record;
 
+      overriding procedure Standard_Output_Available
+        (Self : in out Shell_Listener);
+
+      overriding procedure Standard_Error_Available
+        (Self : in out Shell_Listener);
+
       overriding procedure Finished
         (Self      : in out Shell_Listener;
          Exit_Code : Integer);
@@ -193,6 +215,10 @@ package body Tester.Tests is
         (Self          : in out Shell_Listener;
          Process_Error : Integer);
 
+      --------------------
+      -- Error_Occurred --
+      --------------------
+
       overriding procedure Error_Occurred
         (Self          : in out Shell_Listener;
          Process_Error : Integer) is
@@ -210,6 +236,10 @@ package body Tester.Tests is
          Self.Done := True;
       end Error_Occurred;
 
+      --------------
+      -- Finished --
+      --------------
+
       overriding procedure Finished
         (Self      : in out Shell_Listener;
          Exit_Code : Integer) is
@@ -230,23 +260,85 @@ package body Tester.Tests is
          Self.Done := True;
       end Finished;
 
-      Shell : Spawn.Processes.Process;
+      -----------
+      -- Print --
+      -----------
+
+      procedure Print (V : VSS.Stream_Element_Vectors.Stream_Element_Vector) is
+         use type Ada.Streams.Stream_Element_Count;
+         Decoder : VSS.Strings.Converters.Decoders.Virtual_String_Decoder;
+         Text    : VSS.Strings.Virtual_String;
+      begin
+         if V.Length > 0 then
+            Decoder.Initialize (VSS.Strings.To_Virtual_String ("utf-8"));
+            Text := Decoder.Decode (V);
+            Ada.Text_IO.Put_Line
+              (VSS.Strings.Conversions.To_UTF_8_String (Text));
+         end if;
+      end Print;
+
+      ------------------------------
+      -- Standard_Error_Available --
+      ------------------------------
+
+      overriding procedure Standard_Error_Available
+        (Self : in out Shell_Listener)
+      is
+         use type Ada.Streams.Stream_Element_Count;
+         Data : Ada.Streams.Stream_Element_Array (1 .. 512);
+         Last : Ada.Streams.Stream_Element_Count;
+      begin
+         loop
+            Self.Process.Read_Standard_Error (Data, Last);
+
+            exit when Last < 1;
+
+            for X of Data (1 .. Last) loop
+               Self.Stderr.Append (X);
+            end loop;
+         end loop;
+      end Standard_Error_Available;
+
+      -------------------------------
+      -- Standard_Output_Available --
+      -------------------------------
+
+      overriding procedure Standard_Output_Available
+        (Self : in out Shell_Listener)
+      is
+         use type Ada.Streams.Stream_Element_Count;
+         Data : Ada.Streams.Stream_Element_Array (1 .. 512);
+         Last : Ada.Streams.Stream_Element_Count;
+      begin
+         loop
+            Self.Process.Read_Standard_Output (Data, Last);
+
+            exit when Last < 1;
+
+            for X of Data (1 .. Last) loop
+               Self.Stdout.Append (X);
+            end loop;
+         end loop;
+      end Standard_Output_Available;
 
       Listener : aliased Shell_Listener;
    begin
       for J in 2 .. GNATCOLL.JSON.Length (List) loop
          Args.Append (GNATCOLL.JSON.Get (List, J).Get);
       end loop;
 
-      Shell.Set_Listener (Listener'Unchecked_Access);
-      Shell.Set_Program (Cmd);
-      Shell.Set_Arguments (Args);
-      Shell.Start;
+      Listener.Process.Set_Listener (Listener'Unchecked_Access);
+      Listener.Process.Set_Program (Cmd);
+      Listener.Process.Set_Arguments (Args);
+      Listener.Process.Start;
 
       loop
          Spawn.Processes.Monitor_Loop (Timeout => 10);
          exit when Listener.Done;
       end loop;
+
+      Print (Listener.Stdout);
+      Print (Listener.Stderr);
    end Do_Shell;
 
    --------------

testsuite/ada_lsp/README.md

@@ -94,7 +94,10 @@ should be in server response, but some values have a special meaning:
 
 Property value - array of strings.
 
-Tester launches a shell command taking command and arguments from the array.
+Tester launches an OS process taking command and arguments from the array.
+The primary purpose is to launch a Python like this:
+
+    "shell": ["${PYTHON}", "${DIR}/makelink.py" ]
 
 ### Command `comment`
 

testsuite/ada_lsp/project_symlinks/makelink.py

@@ -0,0 +1,8 @@
+import os
+import os.path
+import sys
+
+dir=os.path.dirname(sys.argv[0])
+link=os.path.join (dir, 'link')
+if not os.path.exists(link):
+    os.symlink('prj', link)

testsuite/ada_lsp/project_symlinks/test.json

@@ -6,7 +6,7 @@
             "the 'link/aaa.ads' file shouldn't be referred as 'prj/aaa.ads'"
         ]
     },  {
-        "shell": ["sh", "-c", "rm -rf ${DIR}/link; ln -s prj ${DIR}/link" ]
+        "shell": ["${PYTHON}", "${DIR}/makelink.py" ]
     },  {
         "start": {
             "cmd": ["${ALS}"]