Merge branch 'mr/thevenoux/gnatcheck#68' into 'master'

Add detector for KP 20273

Closes eng/codepeer/gnatcheck#68

See merge request eng/libadalang/langkit-query-language!619

Author: thvnx

lkql_checker/share/lkql/kp/kp_20273.lkql

@@ -0,0 +1,8 @@
+@check(help="possible occurrence of KP 20273",
+       message="possible occurrence of KP 20273")
+fun kp_20273(node) =
+    |" Flag any iterated association. A Constraint_Error exception
+    |" might incorrectly be raised when evaluating an array
+    |" aggregate written using the Ada 2022 iterated component
+    |" association syntax and known to be empty at compile time.
+    node is IteratedAssoc

testsuite/tests/checks/KP-20273/main.adb

@@ -0,0 +1,29 @@
+pragma Ada_2022;
+
+procedure Main is
+   type Class_Settings_Type is record
+      C : Boolean;
+   end record;
+
+   type Class_Index_Type is range 1 .. 10;
+
+   type Obj_Settings_List_Type is
+     array (Class_Index_Type range <>) of Class_Settings_Type;
+
+   Obj_Settings_List : constant Obj_Settings_List_Type := [];
+
+   type Class_Type is record
+      C2 : Boolean;
+   end record;
+
+   function Create_Obj (Setttings : Class_Settings_Type) return Class_Type is
+   begin
+      return (C2 => True);
+   end Create_Obj;
+
+   Class_List : array (Obj_Settings_List'Range) of Class_Type :=
+     [for I in Obj_Settings_List'Range =>  -- FLAG
+        Create_Obj (Setttings => Obj_Settings_List (I))];
+begin
+   null;
+end Main;

testsuite/tests/checks/KP-20273/prj.gpr

@@ -0,0 +1,2 @@
+project Prj is
+end Prj;

testsuite/tests/checks/KP-20273/test.out

@@ -0,0 +1,6 @@
+main.adb:25:7: rule violation: possible occurrence of KP 20273
+25 |       [for I in Obj_Settings_List'Range =>  -- FLAG
+   | _______^
+26 ||         Create_Obj (Setttings => Obj_Settings_List (I))];
+   ||_______________________________________________________^
+

testsuite/tests/checks/KP-20273/test.yaml

@@ -0,0 +1,3 @@
+driver: checker
+rule_name: kp_20273
+project: prj.gpr

testsuite/tests/gnatcheck/xml_help/test.out

@@ -103,6 +103,7 @@ testsuite_driver: No output file generated by gnatcheck
       <check switch="+Rkp_20186" label="possible occurrence of KP 20186"/>
       <check switch="+Rkp_20227" label="possible occurrence of KP 20227"/>
       <check switch="+Rkp_20229" label="possible occurrence of KP 20229"/>
+      <check switch="+Rkp_20273" label="possible occurrence of KP 20273"/>
       <check switch="+Rkp_ob03_009" label="possible occurrence of KP OB03-009"/>
       <check switch="+Rkp_p226_024" label="possible occurrence of KP P226-024 - global analysis required"/>
       <check switch="+Rkp_q309_014" label="possible occurrence of KP Q309-014"/>
@@ -631,6 +632,7 @@ testsuite_driver: No output file generated by gnatcheck
       <check switch="+Rkp_20186" label="possible occurrence of KP 20186"/>
       <check switch="+Rkp_20227" label="possible occurrence of KP 20227"/>
       <check switch="+Rkp_20229" label="possible occurrence of KP 20229"/>
+      <check switch="+Rkp_20273" label="possible occurrence of KP 20273"/>
       <check switch="+Rkp_ob03_009" label="possible occurrence of KP OB03-009"/>
       <check switch="+Rkp_p226_024" label="possible occurrence of KP P226-024 - global analysis required"/>
       <check switch="+Rkp_q309_014" label="possible occurrence of KP Q309-014"/>