Remove the manual runtime files fetching from the driver

Author: HugoGGuerrier

lkql_checker/src/gnatcheck-compiler.adb

@@ -1519,22 +1519,6 @@ package body Gnatcheck.Compiler is
       end if;
    end GPRbuild_Exec;
 
-   ----------------
-   -- Gnatls_Exec --
-   ----------------
-
-   function Gnatls_Exec return String is
-      use Ada.Strings.Unbounded;
-   begin
-      if Has_Access_To_Codepeer then
-         return "codepeer-gnatls";
-      elsif To_String (Target) /= "" then
-         return To_String (Target) & "-gnatls";
-      else
-         return "gnatls";
-      end if;
-   end Gnatls_Exec;
-
    -------------------------
    -- Set_Compiler_Checks --
    -------------------------

lkql_checker/src/gnatcheck-compiler.ads

@@ -26,9 +26,6 @@ package Gnatcheck.Compiler is
    function GPRbuild_Exec return String;
    --  Return the executable name to use in order to spawn a GPRBuild process
 
-   function Gnatls_Exec return String;
-   --  Return the executable name to use in order to spawn a GNATLS process
-
    --------------------------------------------------------
    -- Using in GNATCHECK checks performed by the compiler --
    --------------------------------------------------------

lkql_checker/src/gnatcheck-source_table.adb

@@ -12,20 +12,15 @@ with Ada.Strings.Unbounded;   use Ada.Strings.Unbounded;
 with Ada.Text_IO;             use Ada.Text_IO;
 
 with GNAT.Directory_Operations;  use GNAT.Directory_Operations;
-with GNAT.Expect;                use GNAT.Expect;
 with GNAT.OS_Lib;                use GNAT.OS_Lib;
-with GNAT.String_Split;          use GNAT.String_Split;
 with GNAT.Table;
 with GNAT.Task_Lock;
 
-with Gnatcheck.Compiler;         use Gnatcheck.Compiler;
 with Gnatcheck.Diagnoses;        use Gnatcheck.Diagnoses;
 with Gnatcheck.Ids;              use Gnatcheck.Ids;
 with Gnatcheck.Output;           use Gnatcheck.Output;
 with Gnatcheck.String_Utilities; use Gnatcheck.String_Utilities;
 
-with GNATCOLL.VFS; use GNATCOLL.VFS;
-
 with GPR2.Build.Source;
 with GPR2.Path_Name;
 with GPR2.Project.Tree;
@@ -34,7 +29,6 @@ with GPR2.Project.View;
 with Langkit_Support.Generic_API.Introspection;
 
 with Libadalang.Analysis;         use Libadalang.Analysis;
-with Libadalang.Auto_Provider;    use Libadalang.Auto_Provider;
 with Libadalang.Project_Provider; use Libadalang.Project_Provider;
 with Libadalang.Iterators;
 with Libadalang.Generic_API;      use Libadalang.Generic_API;
@@ -1400,134 +1394,11 @@ package body Gnatcheck.Source_Table is
    Partition : GPR2_Provider_And_Projects_Array_Access;
 
    function Create_Context return Checker_App.Lkql_Context is
-      Ctx   : Checker_App.Lkql_Context;
-      Files : File_Array_Access;
-      Last  : Natural := 0;
-
-      procedure Add_Runtime_Files;
-      --  Add to Files all the GNAT native runtime files, if found
-
-      -----------------------
-      -- Add_Runtime_Files --
-      -----------------------
-
-      procedure Add_Runtime_Files is
-         Gnatls  : String_Access := Locate_Exec_On_Path (Gnatls_Exec);
-         Verbose : aliased String := "-v";
-         Status  : aliased Integer;
-
-      begin
-         if Gnatls = null then
-            return;
-         end if;
-
-         --  Spawn gnatls -v
-
-         declare
-            use Ada.Directories;
-
-            Output : constant String :=
-              Get_Command_Output (Gnatls.all,
-                                  [Verbose'Unchecked_Access],
-                                  "", Status'Unchecked_Access, True);
-            Lines : String_List_Access;
-            Ada_Include_Path : String_Access;
-            Found : Boolean := False;
-
-            procedure Add_File (Dir : Directory_Entry_Type);
-            --  Add the given directory entry Dir to Files
-
-            --------------
-            -- Add_File --
-            --------------
-
-            procedure Add_File (Dir : Directory_Entry_Type) is
-            begin
-               Last := @ + 1;
-               Files (Last) := Create (+Full_Name (Dir));
-            end Add_File;
-
-         begin
-            if Status /= 0 then
-               Free (Gnatls);
-               return;
-            end if;
-
-            --  and look for the line containing "adainclude"
-
-            for Line of Create (Output, [ASCII.LF, ASCII.CR], Multiple)
-            loop
-               Found := Has_Suffix (Line, "adainclude");
-
-               if Found then
-                  Ada_Include_Path :=
-                    new String'(Remove_Spaces (Line));
-                  exit;
-               end if;
-            end loop;
-
-            Free (Lines);
-
-            if not Found then
-               Free (Gnatls);
-               return;
-            end if;
-
-            --  We then list all the *.ads files.
-            --  We only need to process spec files, runtime body files are not
-            --  needed to analyze user code and will slow down the startup
-            --  phase.
-
-            Search (Ada_Include_Path.all, "*.ads",
-                    Process => Add_File'Access);
-            Free (Ada_Include_Path);
-            Free (Gnatls);
-         end;
-      end Add_Runtime_Files;
-
       Charset : constant String := To_String (Arg.Charset.Get);
-
+      Ctx     : Checker_App.Lkql_Context;
    begin
-      --  If no project specified, create an auto provider with all the source
-      --  files listed in the command line, stored in Temporary_File_Storage,
-      --  as well as all runtime files, these are needed for proper name
-      --  resolution.
-
-      if not Gnatcheck_Prj.Is_Specified then
-         declare
-            procedure Add_File (File_Name : String);
-            --  Add File_Name to Files
-
-            --------------
-            -- Add_File --
-            --------------
-
-            procedure Add_File (File_Name : String) is
-            begin
-               Last := @ + 1;
-               Files (Last) := Create (+File_Name);
-            end Add_File;
-
-         begin
-            Files := new File_Array
-                      (1 .. Natural (Length (Temporary_File_Storage)) + 4096);
-            --  Enough to hold all files on the command line and all runtime
-            --  files.
-
-            Temp_Storage_Iterate (Add_File'Access);
-            Add_Runtime_Files;
-            Ctx.Analysis_Ctx := Create_Context
-              (Charset       => Charset,
-               Unit_Provider => Create_Auto_Provider_Reference
-                                  (Files (1 .. Last), Charset),
-               Event_Handler => EHR_Object);
-            Unchecked_Free (Files);
-         end;
-
-      --  Otherwise use a project unit provider
-
-      elsif  Gnatcheck_Prj.Tree.Is_Defined and then not In_Aggregate_Project
-      then
+      --  Use a project unit provider, even with the implicit project
+      if not In_Aggregate_Project then
          if Partition = null then
             Partition :=
               Create_Project_Unit_Providers (Gnatcheck_Prj.Tree);