Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoH advertisement in reverse proxy setup #7606

Open
3 tasks done
RHBH opened this issue Jan 30, 2025 · 2 comments
Open
3 tasks done

DoH advertisement in reverse proxy setup #7606

RHBH opened this issue Jan 30, 2025 · 2 comments

Comments

@RHBH
Copy link

RHBH commented Jan 30, 2025

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

I'd like to propose a change in the behavior of the HTTPS port based on the user setting.

Current behavior

AGH will advertise it's DoH server with the server name, alongside the HTTPS port and "/dns-query" suffix. Setting the HTTPS port to 0 disable DoH advertisement.

Desired behavior

Enabling unecrypted DoH disable AGH from listening on HTTPS port, while keeping it's behavior of advertising it's DoH server in the HTTPS from config file.

Reason

This will allow users to set the HTTPS port as any port already in use and properly advertise DoH service in reverse proxy environments, which usually have port 443 already in use.

I've seen Windows (and probably most software) trying to connect to DoH servers at port 443 automatically (when they are advertised) while ignoring servers at unconventional ports.

This is an improvement over the "allow_unencrypted_doh" setting, which is useful in reverse proxy setups.

Alternatives considered and additional information

Creating multiple IPs to the host machine, setting different services to listen on different IPs but on the same port.

This technically works, but it is not an ideal solution due the increased complexity of the network stacking.

@timkgh
Copy link

timkgh commented Jan 30, 2025

We also really need separate settings for the admin interface over https vs DoH settings #7598

@RHBH RHBH closed this as completed Jan 31, 2025
@RHBH
Copy link
Author

RHBH commented Jan 31, 2025

In this scenario your dashboard would be the uncrecrypted port, which is okay as you can limit listening to localhost and force all access through the reverse proxy.

@RHBH RHBH reopened this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants