Why is the text "Surrounding ecosystem" not in en.w3string? 🤨

[Onyx-Nostalgia]

Hello,

I am the Thai language translator for this mod and I noticed 👀 that this specific text (shown in the image below) is missing from the w3string file.

I suspect the text displayed in the popup might currently be hardcoded within rer_scripts.min.ws. My question is, why is this the case? ❓ Were there any particular challenges or reasons for this?

P.S.: I haven't worked with Witcher 3 scripting before (and hadn't looked at the scripts until I encountered this). If it's not too complex, could someone please explain the reasoning behind this? 🙏 Alternatively, if it's a relatively straightforward fix, I'd appreciate step-by-step guidance. As a fellow programmer 💻, feel free to discuss this in technical terms!

Thanks for your work on this amazing mod! ✨

[Onyx-Nostalgia]

Here is the code I've tentatively modified to include the relevant texts in en.w3strings.csv. This was a straightforward modification made directly within rer_scripts.min.ws.

You can see the changes I made at these links:

rer_scripts.min.ws
https://github.com/Onyx-Nostalgia/tw3-random-encounters-reworked-thai/blob/ad6f7aacfa75681421df89349d6c4a40b8aac118/mods/modRandomEncountersReworked/content/scripts/local/rer_scripts.min.ws#L12077-L12136C4

en.w3strings.csv
https://github.com/Onyx-Nostalgia/tw3-random-encounters-reworked-thai/blob/ad6f7aacfa75681421df89349d6c4a40b8aac118/mods/mod0RandomEncountersReworked_TH/content/en.w3strings.csv#L556-L561C12

[Aelto]

Hi !

First, thanks for translating the mod. This part of the mod wasn't translated at the time because I wasn't fully sure of how I could code the dynamic strings that would work in all languages. I assumed in some languages comparisons wouldn't be done in the same order as in English and so I simply hard coded the thing.

I'm sure that nowadays it could be localised pretty easily indeed ! I'll have a look at your code this weekend, so that it can be merged before the next release I'm slowly planning (I'm busy with other mods 😄).

If I were to do it, personally I think that I'd first simply the way the data is displayed instead of using fancy wording but I would also use the same trick I used in other places where I'd do a StrReplace("{{key}}", localized_segment).

Thanks for the code snippet!

[Onyx-Nostalgia]

Thank you so much for the quick response! 🙏

Your explanation regarding the dynamic strings and the localization complexities in the initial stages, which led you to choose hardcoding, makes sense. I understand now.

I'm happy to hear you'll be looking at my code this weekend.

Thanks again for all your dedication to your mods. 🤗

[Aelto]

Alright! Sorry it took me longer than anticipated, your implementation is exactly how I'd do it! Are you okay with me using your code as a base for the next update?

[Onyx-Nostalgia]

That's great news! 😊 Certainly, you're welcome to use my code as a base for the next update. I'm happy it was helpful.

Separately, while I was looking around, I also came across another instance of hardcoded text that might be worth looking into:
Onyx-Nostalgia/tw3-random-encounters-reworked-thai@2552e01

Just wanted to flag that in case it's useful!

Thanks again 🤗