Handling Delta with number literal (#78)

AfterShip · Jul 16, 2024 · f770c15 · f770c15
1 parent 5c4ca69
commit f770c15
Show file tree

Hide file tree

Showing 4 changed files with 182 additions and 125 deletions.
diff --git a/parser/parser_column.go b/parser/parser_column.go
@@ -801,10 +801,15 @@ func (p *Parser) tryParseCompressionCodecs(pos Pos) (*CompressionCodec, error) {
 	if err != nil {
 		return nil, err
 	}
-	// parse DELTA if  CODEC(Delta, ZSTD(1))
+	// parse DELTA if  CODEC(Delta, ZSTD(1)) or CODEC(Delta(9), ZSTD(1))
 	var codecType *Ident
 	if strings.ToUpper(name.Name) == "DELTA" {
 		codecType = name
+		// try parse delta level
+		if _, err := p.tryParseCompressionLevel(p.Pos()); err != nil {
+			return nil, err
+		}
+		// consume comma
 		if _, err := p.consumeTokenKind(","); err != nil {
 			return nil, err
 		}

diff --git a/parser/testdata/ddl/create_table_with_codec_delta.sql b/parser/testdata/ddl/create_table_with_codec_delta.sql
@@ -2,6 +2,7 @@ CREATE TABLE IF NOT EXISTS test_local
 (
  `id` UInt64 CODEC(Delta, ZSTD(1)),
  `api_id` UInt64 CODEC(ZSTD(1)),
+ `app_id` UInt64 CODEC(Delta(9), ZSTD(1)),
  `timestamp` DateTime64(9) CODEC(ZSTD(1)),
  INDEX timestamp_index(timestamp) TYPE minmax GRANULARITY 4
 )

diff --git a/parser/testdata/ddl/format/create_table_with_codec_delta.sql b/parser/testdata/ddl/format/create_table_with_codec_delta.sql
@@ -3,6 +3,7 @@ CREATE TABLE IF NOT EXISTS test_local
 (
  `id` UInt64 CODEC(Delta, ZSTD(1)),
  `api_id` UInt64 CODEC(ZSTD(1)),
+ `app_id` UInt64 CODEC(Delta(9), ZSTD(1)),
  `timestamp` DateTime64(9) CODEC(ZSTD(1)),
  INDEX timestamp_index(timestamp) TYPE minmax GRANULARITY 4
 )
@@ -18,6 +19,7 @@ CREATE TABLE IF NOT EXISTS test_local
 (
   `id` UInt64 CODEC(Delta, ZSTD(1)),
   `api_id` UInt64 CODEC(ZSTD(1)),
+  `app_id` UInt64 CODEC(Delta, ZSTD(1)),
   `timestamp` DateTime64(9) CODEC(ZSTD(1)),
   INDEX timestamp_index(timestamp) TYPE minmax GRANULARITY 4
 )